Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup customer schema, remove one (deprecated) field; add ipdb. #39

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

dsprayberry
Copy link
Contributor

Description of change

  • Re-orders the fields listed in the customers.json schema file to alphabetize properties and match Recharge docs for easier long-term maintenance.
  • Removes the shopify_customer_id field which has been removed by Recharge in favor of the external_customer_id object
  • Adds ipdb to the dev install

Manual QA steps

  • Validated object structure via direct API response
  • Successful sync locally

Risks

  • Users may be confused as to why this field is no longer available for selection, but fields are filtered during transform for this tap, so there's no change to request structure and it is not being returned by Recharge on this API version.

Rollback steps

  • revert this branch

Copy link

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests are updated to match the expectations, I'm good with this. Looks like the failures are happening on master as well.

Copy link

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondary approve.

@dsprayberry dsprayberry merged commit de46032 into master Sep 26, 2022
@dsprayberry dsprayberry deleted the fix/customer_schema_cleaning branch September 26, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants