v1.5.4: Increase request timeout to 5 min to align with other taps#126
Merged
Conversation
dsprayberry
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Some objects, namely
MacroInstruction, take longer than 30 seconds for thedescribequery to return in some Salesforce instances.This PR increases the request timeout over all requests to 5 min to A) Match the rest of the taps and the current standard we're pushing through Singer, and B) accomodate the aforementioned discovery request.
QA steps
Risks
Low, this is an established timeout, it has been tested manually, and is confirmed to have worked.
Rollback steps