Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.4: Increase request timeout to 5 min to align with other taps #126

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

dmosorast
Copy link
Contributor

Description of change

Some objects, namely MacroInstruction, take longer than 30 seconds for the describe query to return in some Salesforce instances.

This PR increases the request timeout over all requests to 5 min to A) Match the rest of the taps and the current standard we're pushing through Singer, and B) accomodate the aforementioned discovery request.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Manually tested against a connection that has been hitting this scenario and it has been confirmed to work.

Risks

Low, this is an established timeout, it has been tested manually, and is confirmed to have worked.

Rollback steps

  • revert this branch, release new patch version

@dmosorast dmosorast merged commit 568e82e into master Oct 28, 2021
@dmosorast dmosorast deleted the increase-request-timeout branch October 28, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants