Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-23556 Update PKs #163

Merged
merged 8 commits into from
Aug 14, 2023
Merged

TDL-23556 Update PKs #163

merged 8 commits into from
Aug 14, 2023

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Jul 13, 2023 •
edited by RushiT0122
Loading

Description of change

This PR fixes the primary key for the LightningUriEvent Stream to make what Salesforce Docs says is the unique identifier of the event.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

  • PK changes require a major version bump

Rollback steps

  • revert this branch

dsprayberry
dsprayberry approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@dsprayberry dsprayberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one comment but don't wanna block on it

luandy64
luandy64 commented Aug 2, 2023
View reviewed changes
RushiT0122 added 2 commits August 10, 2023 06:17
@RushiT0122 RushiT0122 merged commit d42bc14 into master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsprayberry dsprayberry dsprayberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luandy64 @dsprayberry @RushiT0122 @shantanu73