Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format for date field on example config.json #55

Merged
merged 2 commits into from Oct 12, 2018

Conversation

dinoshauer
Copy link
Contributor

@dinoshauer dinoshauer commented Oct 12, 2018

Running tap-salesforce --config config.json --discover with the date format from the example config raises an error, it's a pretty straight forward formatting error, still it'd be nice if the correct format was in the README :)

For good measure, this is the output of the above command

$ tap-salesforce --config config.json --discover
CRITICAL time data '2017-11-02' does not match format '%Y-%m-%dT%H:%M:%SZ'
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/singer/utils.py", line 28, in strptime
    return datetime.datetime.strptime(dtime, DATETIME_FMT)
  File "/usr/local/lib/python3.7/_strptime.py", line 577, in _strptime_datetime
    tt, fraction, gmtoff_fraction = _strptime(data_string, format)
  File "/usr/local/lib/python3.7/_strptime.py", line 351, in _strptime
    (bad_directive, format)) from None
ValueError: '0' is a bad directive in format '%04Y-%m-%dT%H:%M:%S.%fZ'

Edit: Also fixes the example command to run in discover mode

@cmerrick
Copy link

Hi @dinoshauer, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

You did it @dinoshauer!

Thank you for signing the Singer Contribution License Agreement.

@briansloane briansloane merged commit 055147c into singer-io:master Oct 12, 2018
@briansloane
Copy link

Thanks @dinoshauer! This looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants