Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize build #103

Merged
merged 1 commit into from May 6, 2021
Merged

Canonicalize build #103

merged 1 commit into from May 6, 2021

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented May 6, 2021

Description of change

Add build to list of fields we canonicalize

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Ran the tap without the change, saw "Build" key. Ran the tap with the change and ensured the record only differs in that "Build" key

Risks

  • Low

Rollback steps

  • revert this branch

@leslievandemark leslievandemark merged commit 754759d into master May 6, 2021
@leslievandemark leslievandemark deleted the canonicalize branch May 6, 2021 15:37
@luandy64 luandy64 mentioned this pull request May 6, 2021
2 tasks
tmck-code pushed a commit to lexerdev/tap-shopify that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants