Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-18653: Fix singer.transform.SchemaMismatch: Errors during transform #149

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

hpatel41
Copy link
Contributor

@hpatel41 hpatel41 commented Apr 19, 2022

Description of change

TDL-18653: Fix singer.transform.SchemaMismatch: Errors during transform

  • For the fields not found in the Shopify Documentation: Removed that field from the schema and added patternProperties to accept every extra incoming field
  • For the fields found in the Shopify Documentation but datatype is not confirmed: Updated schema with empty schema {}

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

@savan-chovatiya savan-chovatiya marked this pull request as ready for review April 19, 2022 09:57
@KrisPersonal KrisPersonal merged commit 382747d into master Apr 29, 2022
@KrisPersonal KrisPersonal mentioned this pull request Apr 29, 2022
2 tasks
RushiT0122 pushed a commit that referenced this pull request May 22, 2023
…rm (#149)

* updated schema to fix transform errors

* added patternProperties for order_refunds stream

* updated schema of order_refunds

* resolve integration test failure

* updated schema for abandoned_checkouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants