Migrate to GraphQL Streams#193
Merged
Merged
Conversation
RushiT0122
reviewed
Jan 23, 2025
| yield obj | ||
|
|
||
| page_info = data.get("pageInfo") | ||
| cursor , has_next_page = page_info.get("endCursor"), page_info.get("hasNextPage") |
Contributor
There was a problem hiding this comment.
Suggested change
| cursor , has_next_page = page_info.get("endCursor"), page_info.get("hasNextPage") | |
| cursor, has_next_page = page_info.get("endCursor"), page_info.get("hasNextPage") |
RushiT0122
reviewed
Jan 23, 2025
RushiT0122
left a comment
Contributor
There was a problem hiding this comment.
I see amount, Price fields are marked string in schema, should those be singer.decimals?
RushiT0122
reviewed
Jan 23, 2025
Comment on lines
+42
to
+47
| resource_alias = { | ||
| "customers":"customer", | ||
| "products":"product", | ||
| "collections": "collection", | ||
| "orders": "order" | ||
| } |
Contributor
There was a problem hiding this comment.
Minor fix, won't block the PR but get it fixed.
Suggested change
| resource_alias = { | |
| "customers":"customer", | |
| "products":"product", | |
| "collections": "collection", | |
| "orders": "order" | |
| } | |
| resource_alias = { | |
| "customers": "customer", | |
| "products": "product", | |
| "collections": "collection", | |
| "orders": "order" | |
| } |
RushiT0122
approved these changes
Jan 23, 2025
Contributor
|
Will wait for integration test PR to get merged for final approval. |
…194) * Add unit test for the graphql scenarios * add teardown * remove metafields from the bookmarks test * add new integ. test for metafields * update foreign keys within meta * fix the failing interrupt sync * Include metafields shop in the bookmarks test * Changes as per the suggestions * update doc string * Camel case the comments * make metafield_dict a object variable * remove trailing spaces
1 task
Member
Author
I have checked the schema and updated the relevant fields to use |
sgandhi1311
approved these changes
Jan 24, 2025
|
@somethingmorerelevant Are there plans to update the other streams? Specifically events? I believe I found a bug related to events but it's irrelvant with the REST API being depreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR Migrates few streams to graphQl due to the upcoming sunset on 01/02/25
Integration tests will be updated in a different pr
Streams that are migrated:
What is changed in each stream
Products
Inventory Items
Metafields
Product Variants
Structural Changes
QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code