Skip to content

Fix GraphQL Client Exception handling and logging#195

Merged
vishalp-dev merged 8 commits into
masterfrom
fix-json-decoding-error
Jan 27, 2025
Merged

Fix GraphQL Client Exception handling and logging#195
vishalp-dev merged 8 commits into
masterfrom
fix-json-decoding-error

Conversation

@vishalp-dev

@vishalp-dev vishalp-dev commented Jan 27, 2025

Copy link
Copy Markdown
Member

Description of change

image

Removed the print statements from the graphQL Client's execute method which were interfering with the target-stitch.
Refer to changes in tap_shopify/streams/graphql/gql_base.py

Current Package Version of SDK:
ShopifyAPI==12.6.0

Link to package impl:

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@vishalp-dev
vishalp-dev merged commit 73dec1e into master Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants