Skip to content

Query and extract multiple pages of products for each collection - #231

Merged
sgandhi1311 merged 1 commit into
singer-io:masterfrom
JJSphar:master
Aug 7, 2025
Merged

sgandhi1311 merged 1 commit into
singer-io:masterfrom
JJSphar:master

Conversation

@JJSphar

@JJSphar JJSphar commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Description of change

This is a one-liner that adjusts the collections stream to extract multiple pages of products sub-results.

Prior to this PR, only the 1st page of collections.products is being extracted for each collection. This is documented in #224.

Specifically, this PR updates the handling in Collections.transform_products to match the shape of the GraphQL API response.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@JJSphar

JJSphar commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

Copying @sgandhi1311 for visibility - as a first-time contributor, please let me know if there's any changes (housekeeping or otherwise) you'd like to see. Thanks for taking a look!

@sgandhi1311

Copy link
Copy Markdown
Member

Copying @sgandhi1311 for visibility - as a first-time contributor, please let me know if there's any changes (housekeeping or otherwise) you'd like to see. Thanks for taking a look!

Thanks for your contribution, @JJSphar! I’ve merged the changes and will be rolling them out to production shortly.

@sgandhi1311
sgandhi1311 merged commit 04b7709 into singer-io:master Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants