Skip to content

Remove invalid singer-decimal formats in locations schema#120

Merged
dmosorast merged 9 commits into
masterfrom
TDL-26572/fix-json-schema-decimal-format
Nov 4, 2024
Merged

Remove invalid singer-decimal formats in locations schema#120
dmosorast merged 9 commits into
masterfrom
TDL-26572/fix-json-schema-decimal-format

Conversation

@bryantgray
Copy link
Copy Markdown
Contributor

@bryantgray bryantgray commented Oct 29, 2024

Description of change

  • Removes invalid singer-decimal format from latitude and longitude in the coordinates field from the locations stream

Manual QA steps

  • N/A. Schema type is still string.

Risks

  • Low. singer-decimal was never a valid format.

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@bryantgray bryantgray changed the title Change invalid singer-decimal to singer.decimal in locations schema Remove invalid singer-decimal in locations schema Nov 4, 2024
@bryantgray bryantgray changed the title Remove invalid singer-decimal in locations schema Remove invalid singer-decimal format in locations schema Nov 4, 2024
@bryantgray bryantgray changed the title Remove invalid singer-decimal format in locations schema Remove invalid singer-decimal formats in locations schema Nov 4, 2024
@dmosorast dmosorast merged commit a144007 into master Nov 4, 2024
@dmosorast dmosorast deleted the TDL-26572/fix-json-schema-decimal-format branch November 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants