Merged
Conversation
* Initial commit * Enhance token chaining * Fix unit tests * Fix pylint issue * Add unit tests * Fix start_date tests * Fix tap-tester issues * Enhance tap testers * Fix pylint * Fix bookmark cursor tests for inventory * Remove debug log * Run tests for all streams * Remove unnecessary changes * Address review comments * Remove returned_quantities field from all_fields test * Resolve review comments * Replace double quotes with single quotes
RushiT0122
requested changes
Jan 16, 2025
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Remove roles references from all the test files.
Contributor
Author
Removed all |
RushiT0122
approved these changes
Jan 16, 2025
rdeshmukh15
reviewed
Jan 16, 2025
tests/base.py
Outdated
| import json | ||
| from datetime import datetime as dt | ||
| from datetime import timedelta | ||
| from tap_tester.jira_client import JiraClient as jira_client |
Contributor
There was a problem hiding this comment.
Imported this twice on line no.12 too
rdeshmukh15
reviewed
Jan 16, 2025
tests/base.py
Outdated
| 'bank_accounts', # No endpoints for CREATE or UPDATE | ||
| 'cash_drawer_shifts', # Require cash transactions (not supported by API) | ||
| 'payouts', # Depenedent on bank_account related transactions, no endpoints for CREATE or UPDATE | ||
| 'employees', # Deprecated stream |
Contributor
There was a problem hiding this comment.
If it is deprecated, can we remove it?
rdeshmukh15
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code