Add backoff logic and fix the failing integration tests #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* exclude few streams from testing * modify interrupt sync test * modified expected streams for test start date
zachharris1
approved these changes
Jun 7, 2023
LesleyDing
pushed a commit
to vibeus/tap-tiktok-ads
that referenced
this pull request
Mar 25, 2024
* add backoff logic for different error codes * replace max_time with max_retries in the backoff logic * add parameterized test cases * Fix the integration test (singer-io#20) * exclude few streams from testing * modify interrupt sync test * modified expected streams for test start date * setup.py and changelog changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For different error codes - 40200, 40201, 40202, 40700, 50002 add the backoff logic. Instead of
max_timeaddedmax_triesin the backoff decorator.Integration test changes - As the support for the dimension - stat_time_day is removed, the records are not available for "ad_insights", "ad_insights_by_age_and_gender", "ad_insights_by_country", "ad_insights_by_platform".
Manual QA steps
Risks
Rollback steps