Skip to content

TDL-22338 add new fields, streams and bug fixes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 20, 2023
Merged

TDL-22338 add new fields, streams and bug fixes #7

merged 11 commits into from
Mar 20, 2023

Conversation

kethan1122
Copy link
Contributor

@kethan1122 kethan1122 commented Mar 15, 2023 •
edited
Loading

Description of change

  • Adds emergency_address_status field to incoming_phone_numbers stream doc_link
  • Adds label field to conference_participants stream
  • Adds reason_conference_ended and call_sid_ending_conference fields to conferences stream
  • Adds price_unit field to messages stream
  • Adds account_balance stream (schema file is already available in the tap-code but stream implementation is missing)

Along with above inclusions, we have also noticed few minor issues:

  1. next_page_url key in API response for alerts stream differs from other streams (alerts has next_page_url and others have next_page_uri) doc_link
  2. usage_records stream extracts duplicate records while using start_date and end_date as query_params(must be an issue with Twilio's API). The fix is to only use start_date as query_param and extract all the records after the start_date and use start_date as replication key
  3. Adds account_sid field to keys stream during process_records
  4. Falls back to default value for date_window_days if the value is not set or set as None or empty-string

Manual QA steps

  • Ran all the standard integration tests(which are currently in TDL-22160-add-integration-tests branch)

Risks

Rollback steps

  • revert this branch

sgandhi1311
sgandhi1311 reviewed Mar 15, 2023
View reviewed changes
sgandhi1311
sgandhi1311 reviewed Mar 15, 2023
View reviewed changes
kethan1122 and others added 4 commits March 17, 2023 09:33
@kethan1122
Tdl 22160 add integration tests (#6)
e0ad192 
* setup circleci

* Update config.yml

* fix community issues

* fix pagination issue

* update query params for calls stream

* updated replication_key and query_param for calls stream

* add basetest for integration tests

* remove replication_keys for full_table stream accounts

* changelog and version bump

* update changelog

* remove foreign keys

* add discovery test

* add pagination test

* add all fields and automatic fields

* deleted old tests

* deleted old test and removed extra lines in circleci config

* add start_date and bookmark test

* PR comments

* update comments

* PR comments

* update bookmarks test

* update pagination test
@kethan1122
changelog and version update
b1275f7
@kethan1122
Merge branch 'TDL-22338-add-fields-streams' of github.com:singer-io/t…
469611c 
…ap-twilio into TDL-22338-add-fields-streams
@kethan1122
update README
fd2c4e3
@kethan1122 kethan1122 merged commit fe70da7 into master Mar 20, 2023
@kethan1122 kethan1122 deleted the TDL-22338-add-fields-streams branch March 20, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslievandemark leslievandemark leslievandemark approved these changes

@sgandhi1311 sgandhi1311 sgandhi1311 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kethan1122 @leslievandemark @sgandhi1311