Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexError bug in landings pagination #51

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

leslievandemark
Copy link
Contributor

@leslievandemark leslievandemark commented Oct 29, 2021

Description of change

The items default to empty list was indexed on and to get an IndexError. This pr checks if items is empty first.

Manual QA steps

Risks

Rollback steps

  • revert this branch

tap_typeform/streams.py Outdated Show resolved Hide resolved
Co-authored-by: Collin Simon <cosimon@users.noreply.github.com>
@leslievandemark leslievandemark merged commit ed82221 into master Oct 29, 2021
@leslievandemark leslievandemark deleted the fix/landings-pagination-bug branch October 29, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants