Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with false positives of 0 & 1 boolean values and circleCI job failure fix #10

Merged
merged 19 commits into from
Jul 20, 2022

Conversation

Vi6hal
Copy link
Member

@Vi6hal Vi6hal commented Jul 15, 2022

transform

Description of change

  • Modified the _transform method of the Transformer class.
  • Formatting and indentation
  • Added chunk decode logic to make code Python version compatible

Manual QA steps

Risks

Rollback steps

  • revert this branch

co-author @rdeshmukh15

@rdeshmukh15 rdeshmukh15 changed the title Fixed issue with false positives of 0 & 1 boolean values Fixed issue with false positives of 0 & 1 boolean values and circleCI job failure fix Jul 19, 2022
Copy link

@savan-chovatiya savan-chovatiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add unit test cases for different scenarios of boolean values?

@rdeshmukh15 rdeshmukh15 merged commit c99a0b5 into master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants