Skip to content

Fixed issue with false positives of 0 & 1 boolean values and circleCI job failure fix#10

Merged
rdeshmukh15 merged 19 commits into
masterfrom
TDL-19091-bool-eval-bugfix
Jul 20, 2022
Merged

Fixed issue with false positives of 0 & 1 boolean values and circleCI job failure fix#10
rdeshmukh15 merged 19 commits into
masterfrom
TDL-19091-bool-eval-bugfix

Conversation

@vishalp-dev

@vishalp-dev vishalp-dev commented Jul 15, 2022

Copy link
Copy Markdown
Member

transform

Description of change

  • Modified the _transform method of the Transformer class.
  • Formatting and indentation
  • Added chunk decode logic to make code Python version compatible

Manual QA steps

Risks

Rollback steps

  • revert this branch

co-author @rdeshmukh15

Comment thread tap_workday_raas/discover.py Outdated
Comment thread tap_workday_raas/discover.py Outdated
Comment thread tap_workday_raas/discover.py Outdated
Comment thread tap_workday_raas/transform.py Outdated
@rdeshmukh15
rdeshmukh15 requested a review from dbshah1212 July 18, 2022 14:24
@rdeshmukh15 rdeshmukh15 changed the title Fixed issue with false positives of 0 & 1 boolean values Fixed issue with false positives of 0 & 1 boolean values and circleCI job failure fix Jul 19, 2022

@savan-chovatiya savan-chovatiya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add unit test cases for different scenarios of boolean values?

@rdeshmukh15
rdeshmukh15 merged commit c99a0b5 into master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants