/ tap-xero Public
v2.0.4: Explicitly check for date while parsing so that
datetime does not match
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Description of change
While debugging a separate issue, I noticed that datetimes of the format
"\/Date(1419937200000+0000)\/"as documented by Xero here were being truncated to
The root of the issue was that
isinstance(value, date)also matches
datetimedata types, so both were going down that path.
This PR makes the check explicitly for
dateonly to avoid any conflict.
Manual QA steps