TDL-590: Added retry logic on JSON decoder error in the filter function #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAllan357
suggested changes
Apr 1, 2021
| config = {} | ||
| tap_stream_id = "contacts" | ||
|
|
||
| global json_decode_error_str |
There was a problem hiding this comment.
Can you remove the global and just define two separate mocked_request functions - one for the failing case (ex: mocked_failed_request (with the bad JSON) and the second for the passing case (ex: mocked_successful_request)
There was a problem hiding this comment.
@KAllan357 Incorporated the change as suggested.
Thank you
|
I requested a change but this looks good other than that. |
KAllan357
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-590: Add retry logic to client "filter" function so it can be retried on error
Manual QA steps
Risks
Rollback steps
Automated tests