Tdl 812 add wait time for rate limit backoff #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tap_xero/client.py
Outdated
| exc_info = sys.exc_info() | ||
| resp = exc_info[1].response | ||
| sleep_time_str = resp.headers.get('Retry-After') | ||
| LOGGER.info("Received 429 -- sleeping for %s seconds", sleep_time_str) |
There was a problem hiding this comment.
@savan-chovatiya Can you change this message as:
"API rate limit exceeded -- sleeping for %s seconds"
There was a problem hiding this comment.
@karanpanchal-crest I have changed the message as per suggestion.
karanpanchal-crest
approved these changes
Apr 21, 2021
KAllan357
approved these changes
Apr 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps