update products schema

[rjh336]

Description of change

Per Yotpo support RE /v1/apps/{app_key}/products endpoint:

our R&D team recently changed the endpoint and the category parameter are no longer supported/deprecated the reason why it shows as null. However, we cannot delete it as it may cause some backward compatibility issues, especially with the customer who still using it. If you are not using it in some cases, kindly disregard this part of the endpoint.

I made updates to category.name and category.id to accept null values

Manual QA steps

Risks

Rollback steps

• revert this branch

[singer-bot]

Hi @rjh336, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

[rjh336]

@KrisPersonal

[dbshah1212]

@KrisPersonal

@rjh336 Can you please sign a contribution license agreement for us to look further?

[rjh336]

@KrisPersonal

@rjh336 Can you please sign a contribution license agreement for us to look further?

@dbshah1212 when I click on the link and authorize I do not get redirected to a web form, nor do I receive and email to sign the CLA

@rjh336 I was able to see the form. Can you check whether there are any browser specific issue? I tried in Chrome

[rjh336]

@KrisPersonal I can sign the form hosted in the CLA heroku app but I do not get an email (not in spam too).

[toandm]

Hi guys, any new feedback here? I'm having the same issue, and this would help us get back to the right track here

[michael-urrutia]

Hi guys, any new feedback here? I'm having the same issue, and this would help us get back to the right track here

+1. @dbshah1212?

[toandm]

@dbshah1212 please take a look at this, we really need it now. Our reports are not updating because of this

[dbshah1212]

Yes we can merge this as changes looks good to me, @rjh336 can you please reissue the CLA?

[dbshah1212]

@dbshah1212 please take a look at this, we really need it now. Our reports are not updating because of this

Yes I can, just waiting for CLA approval

[KrisPersonal]

@rjh336 Please resubmit and CLA should get approved. https://stitch-cla-enforcer.herokuapp.com/

[singer-bot]

You did it @rjh336!

Thank you for signing the Singer Contribution License Agreement.

[rjh336]

@rjh336 Please resubmit and CLA should get approved. https://stitch-cla-enforcer.herokuapp.com/

done @KrisPersonal

[KrisPersonal]

@rjh336 @toandm @michael-urrutia Completed the merge of PR to master

[toandm]

@rjh336 I don't know why but the same error is happening :( I'm using Yotpo connection on Stitch. Here is my error message:
Errors during transform: [category.name: data does not match {'type': 'string'}, category.id: data does not match {'type': 'number'}, category: data does not match {'selected': True, 'inclusion': 'available', 'properties': {'name': {'type': 'string'}, 'id': {'type': 'number'}}, 'type': 'object'}, : data does not match {'selected': True, 'inclusion': 'available', 'properties': {'url': {'selected': True, 'inclusion': 'available', 'type': 'string'}, 'external_product_id': {'selected': True, 'inclusion': 'available', 'type': 'string'}, 'category': {'selected': True, 'inclusion': 'available', 'properties': {'name': {'type': 'string'}, 'id': {'type': 'number'}}, 'type': 'object'}, 'average_score': {'selected': True, 'inclusion': 'available', 'type': 'number'}, 'product_specs': {'selected': True, 'inclusion': 'available', 'type': 'array', 'items': {'properties': {'key': {'type': 'string'}, 'value': {'type': 'string'}}, 'type': 'object'}}, 'updated_at': {'selected': True, 'inclusion': 'available', 'type': 'string', 'format': 'date-time'}, 'description': {'selected': True, 'inclusion': 'available', 'type': ['string', 'null']}, 'images': {'selected': True, 'inclusion': 'available', 'type': 'array', 'items': {'properties': {'facebook_square': {'type': 'string'}, 'original': {'type': 'string'}, 'kind': {'type': 'string'}, 'square': {'type': 'string'}, 'facebook': {'type': 'string'}}, 'type': 'object'}}, 'total_reviews': {'selected': True, 'inclusion': 'available', 'type': 'number'}, 'created_at': {'selected': True, 'inclusion': 'available', 'type': 'string', 'format': 'date-time'}, 'id': {'selected': True, 'inclusion': 'automatic', 'type': 'integer'}, 'name': {'selected': True, 'inclusion': 'available', 'type': 'string'}}, 'type': ['object'], 'additionalProperties': False}]

[rjh336]

Same @toandm

@KrisPersonal @dbshah1212 do either of you work for Stitch? Wondering if Stitch pinned their yotpo deployment to the last release of this tap and need to bump? Or my changes just did not resolve the issue?

[toandm]

nevermind it worked, thanks