Skip to content

Fix Timestamp issue with chats endpoint#54

Merged
rdeshmukh15 merged 3 commits into
masterfrom
tdl-26911
Jan 16, 2025
Merged

Fix Timestamp issue with chats endpoint#54
rdeshmukh15 merged 3 commits into
masterfrom
tdl-26911

Conversation

@vishalp-dev
Copy link
Copy Markdown
Member

@vishalp-dev vishalp-dev commented Jan 14, 2025

Description of change

  • Removes Tz info from query string which is causing a failure for the endpoint
  • Requests package update to 2.32.3
  • Bump version changes in setup.py and CHANGELOG.md

Manual QA steps

  • Tested the fix by running sync and discovery

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Co-authored by @BubbaTLC

@vishalp-dev
Copy link
Copy Markdown
Member Author

vishalp-dev commented Jan 14, 2025

Moving it to draft until we get clarification from zendesk about this change in the api docs

This issue has only appeared since 11th January

@vishalp-dev vishalp-dev marked this pull request as draft January 14, 2025 08:22
Comment thread tap_zendesk_chat/streams.py
@rdeshmukh15 rdeshmukh15 marked this pull request as ready for review January 16, 2025 14:32
@rdeshmukh15 rdeshmukh15 merged commit 06ce4cc into master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants