Skip to content

Backoff for all 5xx errors#93

Merged
KrisPersonal merged 2 commits intomasterfrom
backoff-for-all-5xx-errors
Nov 30, 2021
Merged

Backoff for all 5xx errors#93
KrisPersonal merged 2 commits intomasterfrom
backoff-for-all-5xx-errors

Conversation

@prijendev
Copy link
Copy Markdown
Contributor

Description of change

  • Added back retry mechanism for all 5xx errors.
  • Added unit test cases for 524 and 520 errors.

Manual QA steps

  • Raise Httperror with status code 524 and 520 error and verify retry.

Risks

Rollback steps

  • revert this branch

Copy link
Copy Markdown
Contributor

@kspeer825 kspeer825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@KrisPersonal KrisPersonal merged commit 404a2bd into master Nov 30, 2021
@cosimon cosimon deleted the backoff-for-all-5xx-errors branch November 30, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants