Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce utc in queries in REST api #56

Merged
merged 2 commits into from Apr 29, 2021
Merged

Conversation

zachharris1
Copy link
Contributor

@zachharris1 zachharris1 commented Apr 29, 2021

Description of change

Currently, our REST api queries are not specifying a timezone. Based on code elsewhere in the tap, it looks like we assume no timezone specified means UTC, but we were seeing behavior where that wasn't the case. This change explicitly forces UTC.
See https://knowledgecenter.zuora.com/Central_Platform/Query/Export_ZOQL/G_Dates_and_Datetimes#Specify_time_zones for more info

Manual QA steps

  • I ran a sync that queried the span of an hour and didn't get a known existing record with an updated at within that hour. I then ran a sync that queried the span of that hour, plus three hours before that hour. This sync did get the missing record.
  • I ran the same initial sync that spanned one hour with this change, and the record showed up properly.

Risks

  • Low

Rollback steps

  • revert this branch

@zachharris1 zachharris1 merged commit 6de49c7 into master Apr 29, 2021
@zachharris1 zachharris1 deleted the enforce-utc-in-queries branch April 29, 2021 18:50
@zachharris1 zachharris1 mentioned this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants