Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-21785 Don't add related object to field_dict if unqueryable #73

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

dsprayberry
Copy link
Contributor

Description of change

Related Object identifiers are not necessarily queryable with a given object. If a field is known to cause issues when included as a related object, do not add that field to a stream's field_dict.

Manual QA steps

  • Tested with cloned connection

Risks

  • Low; these fields cannot be queried on related objects currently.

Rollback steps

  • revert this branch

@dsprayberry dsprayberry merged commit ba5a340 into master Jan 31, 2023
@dsprayberry dsprayberry deleted the fix/unsupported_related_objects branch January 31, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants