Fix around image use backspace key can't delete break line.

[TheHeBoy]

Fix around image use backspace key can't delete break line. issue #1306

2023-07-16.11-18-21.mp4

I think EnsureEmbedLineRule and InsertEmbedsRule both apply for embed.EnsureEmbedLineRule only work for video, but InsertEmbedsRule for all embed. Must idea control block or inline element by expend of embed.

/// Handles all format operations which manipulate embeds.
/// This rule wraps line breaks around video, not image.
class InsertEmbedsRule extends InsertRule {
  const InsertEmbedsRule();

  @override
  Delta? applyRule(Delta document, int index,
      {int? len, Object? data, Attribute? attribute}) {
    if (data is String) {
      return null;
    }

    assert(data is Map);

    if (!(data as Map).containsKey(BlockEmbed.videoType)) {
      return null;
    }

[singerdmx]

This PR contains previous changes

[singerdmx]

Can you rebase？

[singerdmx]

Is this about image or video？

[TheHeBoy]

About image.

[singerdmx]

Could you add comment what this is about?

[singerdmx]

It seems that EnsureEmbedLineRule should be renamed to EnsureVideoLineRule?
This rule is only applicable to video?
why is it not applicable to image?

[singerdmx]

Does this change work with content that has video?

[singerdmx]

If you want to exclude image, you can check:

if (_isImage(op) || _isImage(opAfter)) {
   return null;
}

[singerdmx]

You basically want to exclude image from this rule, right?

[singerdmx]

Can you add one line to class comment:

/// This rule applies to video, not image.

[singerdmx]

Please update changelog.
The change makes sense to me now.

[TheHeBoy]

Ok.

[TheHeBoy]

I can't understand when need to update changelog, Every time pr?

[singerdmx]

If this change needs to be published as a new version