Fix regression with parcel name - #825
Merged
Merged
Conversation
internettrans
commented
Jul 5, 2021
| } | ||
|
|
||
| const id = parcelCount++; | ||
| const name = config.name || `parcel-${id}`; |
Member
Author
There was a problem hiding this comment.
Notice that name is referenced on line 62, but wasn't defined
File size impactdist (+256 bytes)Overall impact on dist files size
Detailed impact on dist files size
Impact on dist files cache8 files in you users cache are now outdated because their content have changed.
|
frehner
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug caused by 20fb98a#diff-f6a2de459a33bb86856679dc94eae0ec89e16e8856edea2743fd0e3e781c2337 where
namewas not being defined before it was being used.