Skip to content

Ensure all reroute promises resolve during cancelation. - #831

Merged
internettrans merged 3 commits into
6.0from
fix-cancelation
Jul 10, 2021
Merged

internettrans merged 3 commits into
6.0from
fix-cancelation

Conversation

@internettrans

Copy link
Copy Markdown
Member

I discovered in single-spa/single-spa-layout#143 that in 6.0.0-beta.0 that triggerAppChange() sometimes never resolves due to the bug fixed here. See https://github.com/single-spa/single-spa-layout/actions/runs/1016317472 for the specific failure.

Fixing the bug required changing the tests a bit, but I was able to keep the assertions the same.

@internettrans
internettrans merged commit 4731a37 into 6.0 Jul 10, 2021
@internettrans
internettrans deleted the fix-cancelation branch July 10, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant