Skip to content

Ensure app is unmounted during unregisterApplication. Resolves #871 - #875

Merged
TheMcMurder merged 1 commit into
6.0from
issue-871
Sep 21, 2021
Merged

TheMcMurder merged 1 commit into
6.0from
issue-871

Conversation

@internettrans

@internettrans internettrans commented Sep 20, 2021 •

Copy link
Copy Markdown
Member

See #871. This is technically a breaking change because it's conceivable someone could count on unregisterApplication to wait for applications to naturally unload.

@github-actions

Copy link
Copy Markdown

File size impact


Error: Error while trying to generate a snapshot for 6.0.

Error: Command failed: npm install
npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
npm ERR! code EINVALIDPACKAGENAME
npm ERR! Invalid package name ".pnpm": name cannot start with a period

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2021-09-20T18_25_44_226Z-debug.log

    at ChildProcess.exithandler (node:child_process:397:12)
    at ChildProcess.emit (node:events:394:28)
    at maybeClose (node:internal/child_process:1064:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)

Generated by file size impact during file-size-impact#1254698161

@TheMcMurder TheMcMurder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable approach to the problem.

@TheMcMurder
TheMcMurder merged commit 00c60f4 into 6.0 Sep 21, 2021
@TheMcMurder
TheMcMurder deleted the issue-871 branch September 21, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants