Add author information #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesmit13
reviewed
Jun 12, 2024
Collaborator
kesmit13
left a comment
kesmit13
left a comment
There was a problem hiding this comment.
If the authors key must point to a file in the authors directory, we need to have a check added in resource/nb-check.py to make sure it exists before the notebook is pushed.
kesmit13
reviewed
Jun 12, 2024
Collaborator
kesmit13
left a comment
kesmit13
left a comment
There was a problem hiding this comment.
The check also needs to look for the author image.
Collaborator
Author
|
@kesmit13 Thanks for the feedback, just changed the notebook meta checks (renamed step for clarity), and validated the author entries as well |
tiimgreen
reviewed
Jun 20, 2024
fcmsilva
force-pushed
the
fs/add-author-to-notebook
branch
from
181f22f to
f3867fd
Compare
tiimgreen
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the new notebooks, we'll have 2 main changes: authors and categories.
This change adds the authors to the notebooks (defaults to SingleStore), and includes the authors information/image