added type constructor and parsers for:
Parse V3 signature packets.
Parse V3 pubkey packets.
added UserAttribute Packet
Merge branch 'v2sigs' of git://github.com/singpolyma/OpenPGP-Haskell
Trust packets are really just a type tag that happens to be registered. Nothing about their structure is known. What is the advantage of using a TrustPacket constructor over using UnsupportedPacket ?
These patches seem to use spaces for both indenting as well as alignment. I can clean that up, but in future please use tabs for indentation.
This UserAttribute Packet implementation causes the tests to fail
Oops. Didn't mean to close this.
I've put a cleaned up version of these patches at https://github.com/singpolyma/OpenPGP-Haskell/tree/pull_request_15
I'm still unsure about TrustPacket, and the tests will need to accept UserAttribute. Also, I'd really prefer that UserAttribute actually parse the subpackets usefully: the partial implementation is a bit strange.
The TrustPacket might be useful when parsing f.e. a gpg keyring.
Hmm... I'm not against the TrustPacket, I'm just not sure what it gets you over the UnsupportedPacket. I guess it means you don't have to pattern-match the actual tag number yourself. That might be enough.
made all types derive Data.Data and Data.Typeable
changed version to 0.4.1
Merge branch 'master' of git://github.com/singpolyma/OpenPGP-Haskell
added missing packet type exports - version 0.4.1.1
Similar functionality mainlined at singpolyma@3bd3777
I can't mainline this :)
If Data and Typeable are really needed, they can be derived using the derive tool in a Haskell2010-compatible way. What's your use case for this?
Has this been tested at all? http://tools.ietf.org/html/rfc4880#section-5.3 and http://tools.ietf.org/html/rfc4880#section-3.7 say to me that a full s2k specifier is supposed to be in this packet, not just a one-octet useage.
Equivalent, but correct, functionality added in singpolyma@e2f9358
Similar functionality mainlined at singpolyma@86d6407
Cleaned up and mainlined at singpolyma@60b8c7b
Just parsing to [(Word8, B.ByteString)] makes me a bit uncomfortable. Would prefer to parse the subpackets as with SignatureSubpacket.
are the only feature commits that haven't been in some way merged.