Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to contributing guides #43

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
2 participants
@luizirber
Copy link
Contributor

commented May 13, 2019

Contributing guides had an extra /container-tree in the links:
https://singularityhub.github.io/container-tree/container-tree/contributing/docs/
instead of
https://singularityhub.github.io/container-tree/contributing/docs/

Removed {{ site.baseurl }} from links, and now they should be working.

(part of the JOSS review)

@vsoch

This comment has been minimized.

Copy link
Member

commented May 13, 2019

hey @luizirber ! I just tested locally, and I think what we want to do is keep site.baseurl, and remove site.url. For example, here is the current PR:

image

and then when I change site.url to site.baseurl, all is well!
image

Are you able to reproduce this locally? This is a good fix as long as we get it right. :)

@luizirber luizirber force-pushed the luizirber:fix/contributing branch from 4210e23 to 819e25a May 13, 2019

@luizirber

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

My bad, I didn't have jekyll locally (or even a sane ruby environment... working on fixing that). Seems to be working now!

@vsoch

This comment has been minimized.

Copy link
Member

commented May 13, 2019

No worries - we’re a team! :)

@vsoch vsoch merged commit 134554b into singularityhub:master May 13, 2019

1 check passed

ci/circleci: publish-1 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.