New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GuessActivity and using Starter pattern #44

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@ezisazis
Contributor

ezisazis commented Sep 2, 2017

No description provided.

}
}
}
/**
* Start a new activity to learn an animal
*/
private void learnNewAnimal(Boolean nextReq) {
private void learnNewAnimal() {

This comment has been minimized.

@sinisterstuf

sinisterstuf Nov 10, 2017

Owner

This part is not OK. The learnNewAnimal method is only sometimes called with prevReq (the user's response to the previous question) as an argument, the rest of the time it's called with choice which is the result of their current interaction. So it's not as simple as just use the value we have in prevReq 😉 I'll leave this part out of the PR when applying this patch.

@sinisterstuf

sinisterstuf Nov 10, 2017

Owner

This part is not OK. The learnNewAnimal method is only sometimes called with prevReq (the user's response to the previous question) as an argument, the rest of the time it's called with choice which is the result of their current interaction. So it's not as simple as just use the value we have in prevReq 😉 I'll leave this part out of the PR when applying this patch.

@sinisterstuf sinisterstuf merged commit c3be54e into sinisterstuf:master Nov 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Well done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment