Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #441: update spelling of prop descriptor prop #453

merged 1 commit into from Nov 21, 2022


Copy link

@fatso83 fatso83 commented Nov 21, 2022

Purpose (TL;DR) - mandatory

Fix issue #441 by fixing a spelling error

Background (Problem in detail) - optional

See #441. Node 18.8 seems to have the writable prop of the Performance fields set to false by default and our test did incorrectly try to re-configure it.

Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 95.51% // Head: 95.51% // No change to project coverage 👍

Coverage data is based on head (b450bad) compared to base (62ad45c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #453   +/-   ##
  Coverage   95.51%   95.51%           
  Files           1        1           
  Lines         624      624           
  Hits          596      596           
  Misses         28       28           
Flag Coverage Δ
unit 95.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fake-timers-src.js 95.51% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fatso83 fatso83 merged commit c6ddc8b into main Nov 21, 2022
10 checks passed
@fatso83 fatso83 deleted the 441-node-18.8-failures branch November 21, 2022 11:43
Copy link

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants