Copy unmaintained-text encoding polyfill locally #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatso83
requested changes
Feb 18, 2019
There was a problem hiding this comment.
Thanks for the work, but we need to do this a little bit differently. Having transpiled files makes it hard to do any changes, and we do module bundling anyway.
- Just copy everything in the main
text-endodingrepo intolib/text-encoding, except thepackage.json. - Adjust the references to point to the right folder
- Make sure the tests for text-encoder still runs as part of the bigger test suite.
|
@mantoni I see you already approved this, but do you disagree with my input? Having this part of the package should also include having it in a form that makes it suitable for maintenance (including tests). |
mantoni
dismissed
their stale review
I agree with the points made by @fatso83
|
Hold your horses, btw. I talked to @mantoni about this, which thought we should have an internal fork of the repo. I'll fix this asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
After reading the conversation in #66 seemed that creating a local copy of the deprecated polyfill is the simplest solution. Since the polyfill works fine I didn't like the idea of trying other polyfill that may differ in some subtle way.
This does not modify the license nor makes gives attribution to the original author or the polyfill, wich we should totally be done before this is merged, but I wanted to share this early and be sure it was an approach the maintainers of this library could be happy with.
Thoughts?