Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fake-xhr): Support faking XHR on a given scope #84

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@offirgolan
Copy link
Contributor

offirgolan commented Mar 16, 2019

Resolves #70.

This PR will allow faking the XHR object on a given scope outside of the default global scope. The current implementation exposes a fakeXMLHttpRequestFor method that will generate the fake-xhr module exports for the passed scope. This same method is used internally to generate the contents for the default module with the scope being the default global one.

Before continuing with this PR, I would love to get your feedback on the current implementation so we can finalize the API for this.

  • Finalize API
  • Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.