Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The upgrade of the supports-color package as part of v11 is now breaking tests over non-ES2018 browsers. #2379

Closed
diegocr opened this issue May 25, 2021 · 7 comments

Comments

@diegocr
Copy link

@diegocr diegocr commented May 25, 2021

Describe the bug
Summary says it all, i.e.

25 05 2021 12:31:33.199:INFO [Firefox 60.0 (Linux x86_64)]: Connected on socket 3eTU1cCfGrgUvf7TxzsB with id 79759455
Firefox 60.0 (Linux x86_64) ERROR
  SyntaxError: invalid regexp group
  at node_modules/sinon/pkg/sinon.js:16263:17

Reported to them at chalk/supports-color#111 (comment)

@fatso83
Copy link
Contributor

@fatso83 fatso83 commented May 25, 2021

Hi, thanks for reporting!

If you need support for older browser, use Sinon 9. Starting with Sinon 10 we only support evergreen browsers + Safari: https://github.com/sinonjs/sinon/blob/master/COMPATIBILITY.md

There is not much new in the newer releases 😃

@fatso83 fatso83 closed this May 25, 2021
@diegocr
Copy link
Author

@diegocr diegocr commented May 25, 2021

Hmm, okay. FYI Sinon 10 does work fine in Firefox 60, what we're dealing with here is the use of RegExp's capture groups that is only supported in ES2018+ and therefore you may consider updating that compatibility page to remove the mention of ES2017 😃

@fatso83
Copy link
Contributor

@fatso83 fatso83 commented May 25, 2021

Hmm ... true, that is a bit confusing. The source version of ES is more about what kind of syntax contributors can write, but totally agree it's unfortunate. The supported runtimes still hold, of course, but maybe we should write ES2018. @mroderick ?

@fatso83 fatso83 reopened this May 25, 2021
@diegocr
Copy link
Author

@diegocr diegocr commented May 25, 2021

TBH, i don't think it is worth bumping the ES version requirement of Sinon just because that single package is using something it does not really requires (as i told them in their repo), this is just causing troubles unnecessarily, IMHO.

@fatso83
Copy link
Contributor

@fatso83 fatso83 commented May 26, 2021

No matter what we do about this issue, just be prepared that your Firefox 60 version might still break at any later update: the only runtimes we claim to support are the two latest browser versions of evergreens and officially supported LTS versions of Node.

@fatso83 fatso83 closed this in b18193e May 26, 2021
@diegocr
Copy link
Author

@diegocr diegocr commented May 26, 2021

Thanks for sorting this out.

We're using Firefox 60 ESR to run our Karma tests since that is the lowest Firefox version we do require to support at my company's website. So yeah we're prepared for it, but when there is a good reason - we would also like to use latest versions of all packages as the way to get security advisories sorted.

@mroderick
Copy link
Member

@mroderick mroderick commented Jun 8, 2021

Thank you for reporting this issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants