Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added additional build information for creating one sinon.js file #163

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants

shairez commented Jul 16, 2012

It wasn't clear from the current README.md how to build a single file version of sinon.
Plus, when you wanted to build using "ruby build" on windows, it gave you an error because of the apostrophe mismatch

Contributor

cjohansen commented Jul 16, 2012

The "apostrophe mismatch" is actually something quite different. In Ruby, the backtick will run the contents as a shell command. Changing it to a single quote takes it from copying files to doing nothing :) The reason it doesn't work on Windows is that it doesn't have cp.

The proper solution is to use Ruby to copy the file. Want to take a stab at it? :) http://www.ruby-doc.org/stdlib-1.9.3/libdoc/fileutils/rdoc/FileUtils.html

This pull request passes (merged 64da3f6 into 4fa7a76).

shairez commented Aug 18, 2012

Although I'm not a ruby guy (yet :), I'll look into it,
Thanks

@cjohansen cjohansen closed this Jan 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment