Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundling of cjs module #2412

Merged
merged 2 commits into from Nov 4, 2021
Merged

Conversation

@perrin4869
Copy link
Contributor

@perrin4869 perrin4869 commented Nov 4, 2021

Fix #2411

Webpack can't bundle pkg/sinon.cjs, so going to use the original lib/sinon.js which bundles without issues.
I don't remember right now why I introduced pkg/sinon.cjs anymore ><;;

@fatso83 fatso83 merged commit 51417a3 into sinonjs:master Nov 4, 2021
@fatso83
Copy link
Contributor

@fatso83 fatso83 commented Nov 5, 2021

Thanks for this, btw! Published as 12.0.1

@perrin4869
Copy link
Contributor Author

@perrin4869 perrin4869 commented Nov 5, 2021

Thanks, and sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants