Fixed work with sinon.useFakeTImers() and Rhino.js 1.7R3 #85

Merged
merged 1 commit into from Feb 27, 2012

Projects

None yet

2 participants

Contributor
joymax commented Feb 19, 2012

This is fix for my blog post about Sinon.js and Fake timers: Headless JavaScript testing, Sinon.js, Fake Timers and Rhino.

As promised, I've made environment with Rhino and Sinon.js where test for Fake Timers is not work properly (download). To execute tests use ./runtests.sh.

The main reason of issue is that Rhino.js use global object called global which cause conflict with Sinon.js global object recognition.

I've not wrote regression tests because most of the tests are failed within Rhino.js.

@cjohansen cjohansen merged commit e30b649 into sinonjs:master Feb 27, 2012
Contributor

Thanks. I'll look into making the tests run properly on Rhino too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment