New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed work with sinon.useFakeTImers() and Rhino.js 1.7R3 #85

Merged
merged 1 commit into from Feb 27, 2012

Conversation

Projects
None yet
2 participants
@joymax
Contributor

joymax commented Feb 19, 2012

This is fix for my blog post about Sinon.js and Fake timers: Headless JavaScript testing, Sinon.js, Fake Timers and Rhino.

As promised, I've made environment with Rhino and Sinon.js where test for Fake Timers is not work properly (download). To execute tests use ./runtests.sh.

The main reason of issue is that Rhino.js use global object called global which cause conflict with Sinon.js global object recognition.

I've not wrote regression tests because most of the tests are failed within Rhino.js.

cjohansen added a commit that referenced this pull request Feb 27, 2012

Merge pull request #85 from joymax/master
Fixed work with sinon.useFakeTImers() and Rhino.js 1.7R3

@cjohansen cjohansen merged commit e30b649 into sinonjs:master Feb 27, 2012

@cjohansen

This comment has been minimized.

Show comment
Hide comment
@cjohansen

cjohansen Feb 27, 2012

Contributor

Thanks. I'll look into making the tests run properly on Rhino too.

Contributor

cjohansen commented Feb 27, 2012

Thanks. I'll look into making the tests run properly on Rhino too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment