New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jade version to support block code #543

Closed
chharvey opened this Issue Mar 9, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@chharvey

chharvey commented Mar 9, 2016

I'm not exactly sure which version of Jade this package is dependent on, since it is not listed under the package.json's dependencies or devDependencies. If that were more clear, I would have simply submitted a pull request.

Anyhow, when I run a static server (with $ harp server) and attempt to view my Jade file in the browser, it does not compile because of the unbuffered block code.

-
  var data = {
    heading: 'hello'
  }
h1= data.heading

However, it does compile when single-line unbuffered code is used.

- var data = { heading: 'hello' }
h1= data.heading

The block code syntax is supported in Jade v1.11.0. Please upgrade Harp to the latest version of Jade.

@chharvey chharvey changed the title from upgrade jade version to upgrade jade version to support block code Mar 9, 2016

@lunelson

This comment has been minimized.

lunelson commented Apr 15, 2016

This will be fixed as soon as #526 is merged

@chharvey

This comment has been minimized.

chharvey commented Apr 18, 2016

also, keep in mind:
pugjs/pug#2184

@chharvey

This comment has been minimized.

chharvey commented Apr 26, 2016

Looks like this issue (sintaxi/terraform#114) has been fixed in terraform v1.0.0. harp just needs to upgrade to that (it is still depending on terraform v0.13.2) as covered in #526

@sintaxi

This comment has been minimized.

Owner

sintaxi commented Nov 26, 2016

I believe this issue is now resolved.

@chharvey chharvey closed this Apr 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment