New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sass #71

Closed
lmartins opened this Issue Aug 17, 2013 · 28 comments

Comments

Projects
None yet
@lmartins

lmartins commented Aug 17, 2013

Since there is now a C based Sass compiler (https://github.com/hcatlin/libsass), with a wrapper based in node (https://github.com/andrew/node-sass) Im guessing this could possibly be done.

@ghost ghost assigned sintaxi Aug 17, 2013

@silentrob

This comment has been minimized.

Show comment
Hide comment
@silentrob

silentrob Aug 23, 2013

Collaborator

Do we want Sass or the new SCSS or does it really matter?

Collaborator

silentrob commented Aug 23, 2013

Do we want Sass or the new SCSS or does it really matter?

@lmartins

This comment has been minimized.

Show comment
Hide comment
@lmartins

lmartins Aug 23, 2013

Personally I would go for scss, but there's also many who prefer the sass syntax.
The scss syntax seems to be default/frontmost option for the folks behind Sass.

lmartins commented Aug 23, 2013

Personally I would go for scss, but there's also many who prefer the sass syntax.
The scss syntax seems to be default/frontmost option for the folks behind Sass.

@kennethormandy

This comment has been minimized.

Show comment
Hide comment
@kennethormandy

kennethormandy Aug 23, 2013

Collaborator

Based on #54 (comment), conceptually I think we’d like to support both. CSS would have two whitespace sensitive pre-processors (Sass and Stylus) and two superset pre-processors (LESS and SCSS).

That said, it looks like hcatlin/libsass supports only SCSS. 😿 If we’re only going to have one, it should definitely be SCSS, but I’d like to see both in Harp if possible.

Edit
Here’s the issue for .sass support in libsass. sass/libsass#16

Collaborator

kennethormandy commented Aug 23, 2013

Based on #54 (comment), conceptually I think we’d like to support both. CSS would have two whitespace sensitive pre-processors (Sass and Stylus) and two superset pre-processors (LESS and SCSS).

That said, it looks like hcatlin/libsass supports only SCSS. 😿 If we’re only going to have one, it should definitely be SCSS, but I’d like to see both in Harp if possible.

Edit
Here’s the issue for .sass support in libsass. sass/libsass#16

@aexmachina

This comment has been minimized.

Show comment
Hide comment
@aexmachina

aexmachina Sep 10, 2013

Any idea when/if this will make it into Harp?

I agree with all the comments above, but my vote is for SASS.

aexmachina commented Sep 10, 2013

Any idea when/if this will make it into Harp?

I agree with all the comments above, but my vote is for SASS.

@kennethormandy

This comment has been minimized.

Show comment
Hide comment
@kennethormandy

kennethormandy Sep 10, 2013

Collaborator

Hey @SimonWade,

I’ve been testing SCSS support and I’d say it’s going well. Harp needs to stays as easy to install as it is now; this is where the current effort is going. The discussion is here: sintaxi/terraform#3

Not supporting the indented syntax was briefly discussed since we thought it might be dropped, but I’ve since found this:

There seems to be some disconnect between fact and fiction surrounding the Sass indented syntax. To be clear, the Sass indented syntax has not been and will never be deprecated!

—Adam Stacoviak, Sass’s indented syntax has not been and will never be deprecated!

…the indented syntax will continue to be fully supported. There continues to be confusion about this, so I’ll repeat: the Sass indented syntax has not been and will never be deprecated.

—Nathan Weizenbaum, The Indented Sass Syntax is Here to Stay

So I’m not where that’s been coming from.

In any case, it will definitely be the most inconvenient to implement, but I do have a couple of ideas. Requiring the Gem has been ruled out since Harp should just take care of it. I would love to see node-sass-indented working. If you have any comments on either matter, we’d love feedback or help here.

Collaborator

kennethormandy commented Sep 10, 2013

Hey @SimonWade,

I’ve been testing SCSS support and I’d say it’s going well. Harp needs to stays as easy to install as it is now; this is where the current effort is going. The discussion is here: sintaxi/terraform#3

Not supporting the indented syntax was briefly discussed since we thought it might be dropped, but I’ve since found this:

There seems to be some disconnect between fact and fiction surrounding the Sass indented syntax. To be clear, the Sass indented syntax has not been and will never be deprecated!

—Adam Stacoviak, Sass’s indented syntax has not been and will never be deprecated!

…the indented syntax will continue to be fully supported. There continues to be confusion about this, so I’ll repeat: the Sass indented syntax has not been and will never be deprecated.

—Nathan Weizenbaum, The Indented Sass Syntax is Here to Stay

So I’m not where that’s been coming from.

In any case, it will definitely be the most inconvenient to implement, but I do have a couple of ideas. Requiring the Gem has been ruled out since Harp should just take care of it. I would love to see node-sass-indented working. If you have any comments on either matter, we’d love feedback or help here.

@danawoodman

This comment has been minimized.

Show comment
Hide comment
@danawoodman

danawoodman Oct 4, 2013

👍 for Sass support. Don't see why supporting .sass and .scss shouldn't be possible.

danawoodman commented Oct 4, 2013

👍 for Sass support. Don't see why supporting .sass and .scss shouldn't be possible.

@sintaxi

This comment has been minimized.

Show comment
Hide comment
@sintaxi

sintaxi Oct 4, 2013

Owner

@danawoodman yep, it's in the works.

Owner

sintaxi commented Oct 4, 2013

@danawoodman yep, it's in the works.

@fcoury

This comment has been minimized.

Show comment
Hide comment
@fcoury

fcoury Oct 4, 2013

👍 for this.

fcoury commented Oct 4, 2013

👍 for this.

@Apathetic012

This comment has been minimized.

Show comment
Hide comment
@Apathetic012

Apathetic012 Oct 5, 2013

Would it be possible to add support for compass plugins/configuration as well?

Apathetic012 commented Oct 5, 2013

Would it be possible to add support for compass plugins/configuration as well?

@kennethormandy

This comment has been minimized.

Show comment
Hide comment
@kennethormandy

kennethormandy Oct 5, 2013

Collaborator

@Apathetic012 Great question, it’s definitely something we’re trying to be on top of. More details in #113.

Collaborator

kennethormandy commented Oct 5, 2013

@Apathetic012 Great question, it’s definitely something we’re trying to be on top of. More details in #113.

@dw2

This comment has been minimized.

Show comment
Hide comment
@dw2

dw2 Oct 9, 2013

Casting my vote for the .sass flavor.

dw2 commented Oct 9, 2013

Casting my vote for the .sass flavor.

@aexmachina

This comment has been minimized.

Show comment
Hide comment
@aexmachina

aexmachina Oct 9, 2013

I also prefer the SASS flavour, but it's only supported by the Ruby implementation (not libsass) and it's too slow. I'm happy to use SCSS if it means I get the speed of libsass, also it makes it easy to copy and paste from Dev Tools.

aexmachina commented Oct 9, 2013

I also prefer the SASS flavour, but it's only supported by the Ruby implementation (not libsass) and it's too slow. I'm happy to use SCSS if it means I get the speed of libsass, also it makes it easy to copy and paste from Dev Tools.

@dw2

This comment has been minimized.

Show comment
Hide comment
@dw2

dw2 Oct 9, 2013

Yeah. I'm both a Rails guy and a Node guy, so I think I'll just have to embrace both syntaxes. I was feeling inspired, so I rewrote my mixin library in Stylus after posting my original comment: https://github.com/dw2/mix-master

dw2 commented Oct 9, 2013

Yeah. I'm both a Rails guy and a Node guy, so I think I'll just have to embrace both syntaxes. I was feeling inspired, so I rewrote my mixin library in Stylus after posting my original comment: https://github.com/dw2/mix-master

@aexmachina

This comment has been minimized.

Show comment
Hide comment
@aexmachina

aexmachina Oct 9, 2013

Yeah, if you like the .sass syntax then Stylus is a good option.

aexmachina commented Oct 9, 2013

Yeah, if you like the .sass syntax then Stylus is a good option.

@commadelimited

This comment has been minimized.

Show comment
Hide comment
@commadelimited

commadelimited Oct 13, 2013

My vote would be for SCSS syntax. Not rushing at all, but is there an idea of when Sass support will land in Harp?

commadelimited commented Oct 13, 2013

My vote would be for SCSS syntax. Not rushing at all, but is there an idea of when Sass support will land in Harp?

@kennethormandy

This comment has been minimized.

Show comment
Hide comment
@kennethormandy

kennethormandy Oct 13, 2013

Collaborator

@SimonWade @dw2 @commadelimited

SCSS syntax should be in Harp when this issue is closed: sass/node-sass#148
We have a working version of Harp with SCSS, but want to make sure adding it doesn’t alter anyone’s experience of installing Harp.

The indented syntax will be the easiest to add if this issue is taken care of: sass/libsass#16
This seems unlikely, however, so I’ve spent some time exploring other options, like emirotin/node-sass-indented. Any help here would be greatly appreciated—getting support for the .sass syntax is basically an entirely different issue, unfortunately.

Collaborator

kennethormandy commented Oct 13, 2013

@SimonWade @dw2 @commadelimited

SCSS syntax should be in Harp when this issue is closed: sass/node-sass#148
We have a working version of Harp with SCSS, but want to make sure adding it doesn’t alter anyone’s experience of installing Harp.

The indented syntax will be the easiest to add if this issue is taken care of: sass/libsass#16
This seems unlikely, however, so I’ve spent some time exploring other options, like emirotin/node-sass-indented. Any help here would be greatly appreciated—getting support for the .sass syntax is basically an entirely different issue, unfortunately.

@commadelimited

This comment has been minimized.

Show comment
Hide comment
@commadelimited

commadelimited Oct 13, 2013

Thanks Kenneth. I'm planning on submitting a Harp based topic to a few 2014 conferences including jQCon in San Diego. I just heard about it for the first time this week, but it sounds awesome.

commadelimited commented Oct 13, 2013

Thanks Kenneth. I'm planning on submitting a Harp based topic to a few 2014 conferences including jQCon in San Diego. I just heard about it for the first time this week, but it sounds awesome.

@sintaxi

This comment has been minimized.

Show comment
Hide comment
@sintaxi

sintaxi Oct 13, 2013

Owner

@commadelimited here it is plain and simple. When node-sass can reliably be installed without any dependencies other than NodeJS, then it will be added to harp in a hurry. Also, mocha should not be a hard dependency either (it currently is).

Owner

sintaxi commented Oct 13, 2013

@commadelimited here it is plain and simple. When node-sass can reliably be installed without any dependencies other than NodeJS, then it will be added to harp in a hurry. Also, mocha should not be a hard dependency either (it currently is).

@commadelimited

This comment has been minimized.

Show comment
Hide comment
@commadelimited

commadelimited Oct 13, 2013

@sintaxi, that's a plain enough response. Thanks. Looking forward to hearing the good news. :D

commadelimited commented Oct 13, 2013

@sintaxi, that's a plain enough response. Thanks. Looking forward to hearing the good news. :D

@edrex

This comment has been minimized.

Show comment
Hide comment
@edrex

edrex Oct 27, 2013

Contributor

looks like sass/node-sass#148 closed a few days after the last comments, so is this unblocked?

Contributor

edrex commented Oct 27, 2013

looks like sass/node-sass#148 closed a few days after the last comments, so is this unblocked?

@spieglio

This comment has been minimized.

Show comment
Hide comment
@spieglio

spieglio Oct 31, 2013

Casting my vote for the .sass flavor.

spieglio commented Oct 31, 2013

Casting my vote for the .sass flavor.

@lanceguyatt

This comment has been minimized.

Show comment
Hide comment
@lanceguyatt

lanceguyatt Nov 6, 2013

I'd be super happy with support for .scss and compass :D

lanceguyatt commented Nov 6, 2013

I'd be super happy with support for .scss and compass :D

@edrex

This comment has been minimized.

Show comment
Hide comment
@edrex

edrex Nov 18, 2013

Contributor

@sintaxi it seems like the mocha dependency is used to verify that the binary works at install time. Is that a blocker?

I'm keen to try this out. Are there any changes needed on the Harp side or is it all Terraform?

Contributor

edrex commented Nov 18, 2013

@sintaxi it seems like the mocha dependency is used to verify that the binary works at install time. Is that a blocker?

I'm keen to try this out. Are there any changes needed on the Harp side or is it all Terraform?

@silentrob

This comment has been minimized.

Show comment
Hide comment
@silentrob

silentrob Nov 18, 2013

Collaborator

@edrex I think we can live with the mocha dependancy for now. The code is mostly in Terraform with a small change in harp to expose the extension.

Collaborator

silentrob commented Nov 18, 2013

@edrex I think we can live with the mocha dependancy for now. The code is mostly in Terraform with a small change in harp to expose the extension.

@edrex

This comment has been minimized.

Show comment
Hide comment
@edrex

edrex Nov 19, 2013

Contributor

Seems to work with Harp master, I think the change went in as 66ca961.

Contributor

edrex commented Nov 19, 2013

Seems to work with Harp master, I think the change went in as 66ca961.

@og2t

This comment has been minimized.

Show comment
Hide comment
@og2t

og2t Dec 19, 2013

+1 here, the only thing stopping me from entirely loving HarpJS is the lack of SASS support.

og2t commented Dec 19, 2013

+1 here, the only thing stopping me from entirely loving HarpJS is the lack of SASS support.

@kennethormandy

This comment has been minimized.

Show comment
Hide comment
@kennethormandy

kennethormandy Dec 30, 2013

Collaborator

Hey everyone,

We’re happy to announce the latest version of Harp supports Sass via the SCSS syntax! You can read the full details in the Harp v0.11.0 blog post. To get started right away, upgrade or instal Harp with sudo npm -g install harp (omit sudo if you’re using Windows).

Many of you were also interested in using the .sass syntax, which I’m still exploring possibilities for. I’ve opened a new issue for it here, and counted all your original +1s. Thanks for your interest! You can also follow Harp on Twitter or subscribe to Harp Weekly if you’d like to hear from us more often.

Collaborator

kennethormandy commented Dec 30, 2013

Hey everyone,

We’re happy to announce the latest version of Harp supports Sass via the SCSS syntax! You can read the full details in the Harp v0.11.0 blog post. To get started right away, upgrade or instal Harp with sudo npm -g install harp (omit sudo if you’re using Windows).

Many of you were also interested in using the .sass syntax, which I’m still exploring possibilities for. I’ve opened a new issue for it here, and counted all your original +1s. Thanks for your interest! You can also follow Harp on Twitter or subscribe to Harp Weekly if you’d like to hear from us more often.

@og2t

This comment has been minimized.

Show comment
Hide comment
@og2t

og2t Dec 30, 2013

Great news Kenneth!

Looking forward to .sass syntax :)

T

On 30 December 2013 22:41, Kenneth Ormandy notifications@github.com wrote:

Hey everyone,

We’re happy to announce the latest version of Harp supports Sass via the
SCSS syntax! You can read the full details in the Harp v0.11.0 blog posthttp://harpjs.com/blog/v0-11-0-sass-support.
To get started right away, upgrade or instal Harp with sudo npm -g
install harp (omit sudo if you’re using Windows).

Many of you were also interested in using the .sass syntax, which I’m
still exploring possibilities for. I’ve opened a new issue for it herehttps://github.com/sintaxi/harp/issues/185,
and counted all your original +1s. Thanks for your interest! You can also follow
Harp on Twitter http://twitter.com/harpwebserver or subscribe to Harp
Weeklyhttp://harpjs.us7.list-manage1.com/subscribe?u=af92eba03471187c8aa0266e7&id=74381fea66if you’d like to hear from us more often.


Reply to this email directly or view it on GitHubhttps://github.com/sintaxi/harp/issues/71#issuecomment-31370563
.

og2t commented Dec 30, 2013

Great news Kenneth!

Looking forward to .sass syntax :)

T

On 30 December 2013 22:41, Kenneth Ormandy notifications@github.com wrote:

Hey everyone,

We’re happy to announce the latest version of Harp supports Sass via the
SCSS syntax! You can read the full details in the Harp v0.11.0 blog posthttp://harpjs.com/blog/v0-11-0-sass-support.
To get started right away, upgrade or instal Harp with sudo npm -g
install harp (omit sudo if you’re using Windows).

Many of you were also interested in using the .sass syntax, which I’m
still exploring possibilities for. I’ve opened a new issue for it herehttps://github.com/sintaxi/harp/issues/185,
and counted all your original +1s. Thanks for your interest! You can also follow
Harp on Twitter http://twitter.com/harpwebserver or subscribe to Harp
Weeklyhttp://harpjs.us7.list-manage1.com/subscribe?u=af92eba03471187c8aa0266e7&id=74381fea66if you’d like to hear from us more often.


Reply to this email directly or view it on GitHubhttps://github.com/sintaxi/harp/issues/71#issuecomment-31370563
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment