Some code clean-up. #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also merged 2 functions that did exactly the same thing.
accek
approved these changes
May 17, 2018
Codecov Report
@@ Coverage Diff @@
## develop #39 +/- ##
===========================================
+ Coverage 68.87% 69.06% +0.18%
===========================================
Files 26 26
Lines 1783 1768 -15
===========================================
- Hits 1228 1221 -7
+ Misses 555 547 -8
Continue to review full report at Codecov.
|
accek
pushed a commit
that referenced
this pull request
May 21, 2018
* Moved utils.py from client to package-root. Also merged 2 functions that did exactly the same thing. * Removed unused function duplicate and renamed utils to not be private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.