Add option to measure time and memory consumption with time
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonowak
reviewed
Jun 2, 2023
tonowak
reviewed
Jun 12, 2023
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
tonowak
reviewed
Jun 13, 2023
Collaborator
tonowak
left a comment
tonowak
left a comment
There was a problem hiding this comment.
Hopefully last comments and suggestions:
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
tonowak
approved these changes
Jun 15, 2023
Collaborator
tonowak
left a comment
tonowak
left a comment
There was a problem hiding this comment.
Looks good! I left one comment, you can merge after resolving it (or after ignoring it, it's not an important comment).
Fix execution status order
Tests for measuring with `time`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added tests in another PR #21