Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add METHOD_ADDED_TO_PUBLIC_CLASS check #241

Closed
kingle opened this issue Jun 28, 2019 · 5 comments
Closed

Add METHOD_ADDED_TO_PUBLIC_CLASS check #241

kingle opened this issue Jun 28, 2019 · 5 comments

Comments

@kingle
Copy link
Contributor

kingle commented Jun 28, 2019

For semantic version checks, many of us take the stance that if a public method is added to a public class, most likely it is introducing new functionality and the version should be a MINOR bump. It would be nice to have the ability to allow a configuration to enforce a MINOR version bump if we have configured breakBuildBasedOnSemanticVersioning and a new public method is added (on a public class).

@siom79
Copy link
Owner

siom79 commented Jun 28, 2019

Did you try overrideCompatibilityChangeParameter?

@kingle
Copy link
Contributor Author

kingle commented Jun 28, 2019

That's what I'm trying to do, but I do not see the appropriate check available to override.

@siom79
Copy link
Owner

siom79 commented Jun 28, 2019

You are right. I have to add it.

@dannil
Copy link

dannil commented Oct 27, 2019

Any update on this? Would be a great feature to have as I'm experiencing the same issue.

@siom79 siom79 closed this as completed in b5bba09 Nov 24, 2019
@siom79
Copy link
Owner

siom79 commented Dec 24, 2019

Released with 0.14.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants