Skip to content
Permalink
Branch: taproot
Commits on May 1, 2019
  1. [TESTS] Tests for Taproot/Schnorr/Tapscript

    sipa committed Apr 16, 2019
    Includes sighashing code and many tests by Johnson Lau.
  2. Activate taproot on regtest

    sipa committed Apr 18, 2019
  3. Taproot policy change

    jl2012 authored and sipa committed Apr 15, 2019
  4. Tapscript

    jl2012 authored and sipa committed Apr 9, 2019
Commits on Apr 22, 2019
  1. Taproot validation

    sipa committed Apr 8, 2019
    This includes key path spending and script path spending, but not the
    Tapscript execution implementation.
  2. Implement Taproot signature validation

    jl2012 authored and sipa committed Apr 4, 2019
    * Integration into CheckSig by Pieter Wuille.
Commits on Apr 18, 2019
  1. Add comments to Python ECDSA implementation

    jnewbery authored and sipa committed Apr 18, 2019
  2. Pure python EC

    sipa committed Apr 15, 2019
    This removes the dependency on OpenSSL for the interaction tests, by providing a pure-Python
    toy implementation of secp256k1.
Commits on Apr 1, 2019
  1. Include Schnorrsig module

    sipa committed Apr 1, 2019
  2. Squashed 'src/secp256k1/' changes from b19c000063..763484a1e5

    sipa committed Apr 1, 2019
    763484a1e5 f fix undefined behavior when shifting an int 31 places
    5af66e7f79 f expose nonce_function_bipschnorr
    594e3abb69 f hash noncedata into nonce in nonce_function_bipschnorr
    318d55155c f make helper functions static
    d65adc82f8 Add schnorrsig module which implements BIP-schnorr [0] compatible signing, verification and batch verification.
    f4153a29ab add chacha20 function
    REVERT: b19c000063 Merge bitcoin#607: Use size_t shifts when computing a size_t
    REVERT: 4d01bc2d9c Merge bitcoin#606: travis: Remove unused sudo:false
    REVERT: e6d01e9347 Use size_t shifts when computing a size_t
    REVERT: 7667532bd7 travis: Remove unused sudo:false
    REVERT: ee99f12f3d Merge bitcoin#599: Switch x86_64 asm to use "i" instead of "n" for immediate values.
    REVERT: d58bc93f2c Switch x86_64 asm to use "i" instead of "n" for immediate values.
    REVERT: 05362ee042 Merge bitcoin#597: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
    REVERT: 83483869ac Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
    REVERT: aa15154a48 Merge bitcoin#568: Fix integer overflow in ecmult_multi_var when n is large
    REVERT: 2277af5ff0 Fix integer overflow in ecmult_multi_var when n is large
    REVERT: 85d0e1bcce Merge bitcoin#591: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
    REVERT: 14196379ec Merge bitcoin#580: Add trivial ecmult_multi algorithm which does not require a scratch space
    REVERT: a697d82da9 Add trivial ecmult_multi to the benchmark tool
    REVERT: bade617417 Add trivial ecmult_multi algorithm. It is selected when no scratch space is given and just multiplies and adds the points.
    REVERT: 5545e13dea Merge bitcoin#584: configure: Use CFLAGS_FOR_BUILD when checking native compiler
    REVERT: 20c5869df2 Merge bitcoin#516: improvements to random seed in src/tests.c
    REVERT: b76e45d5d6 Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
    REVERT: 870a977644 Merge bitcoin#562: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
    REVERT: be40c4d0b5 Fixup for C90 mixed declarations.
    REVERT: c71dd2c08f Merge bitcoin#509: Fix algorithm selection in bench_ecmult
    REVERT: 6492bf88cc Merge bitcoin#518: Summarize build options after running configure
    REVERT: 0e9ada1941 Merge bitcoin#567: Correct order of libs returned on pkg-config --libs --static libsecp2…
    REVERT: e96901a4b9 Merge bitcoin#587: Make randomization of a non-signing context a noop
    REVERT: 58df8d03ad Merge bitcoin#511: Portability fix for the configure scripts generated
    REVERT: 2ebdad772a Merge bitcoin#552: Make constants static:
    REVERT: 1c131affd3 Merge bitcoin#551: secp256k1_fe_sqrt: Verify that the arguments don't alias.
    REVERT: ba698f883b Merge bitcoin#539: Assorted minor corrections
    REVERT: 949e85b009 Merge bitcoin#550: Optimize secp256k1_fe_normalize_weak calls.
    REVERT: a34bcaadf1 Actually pass CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD to linker
    REVERT: 2d5f4cebdc configure: Use CFLAGS_FOR_BUILD when checking native compiler
    REVERT: b408c6a8b2 Merge bitcoin#579: Use __GNUC_PREREQ for detecting __builtin_expect
    REVERT: 6198375218 Make randomization of a non-signing context a noop
    REVERT: c663397f46 Use __GNUC_PREREQ for detecting __builtin_expect
    REVERT: e34ceb333b Merge bitcoin#557: Eliminate scratch memory used when generating contexts
    REVERT: b3bf5f99a3 ecmult_impl: expand comment to explain how effective affine interacts with everything
    REVERT: efa783f8f0 Store z-ratios in the 'x' coord they'll recover
    REVERT: ffd3b346fe add `secp256k1_ge_set_all_gej_var` test which deals with many infinite points
    REVERT: 84740acd2a ecmult_impl: save one fe_inv_var
    REVERT: 47045270fa ecmult_impl: eliminate scratch memory used when generating context
    REVERT: 7f7a2ed3a8 ecmult_gen_impl: eliminate scratch memory used when generating context
    REVERT: 314a61d724 Merge bitcoin#553: add static context object which has no capabilities
    REVERT: 89a20a8945 Correct order of libs returned on pkg-config --libs --static libsecp256k1 call.
    REVERT: d3cb1f95eb Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
    REVERT: 40fde611bd prevent attempts to modify `secp256k1_context_no_precomp`
    REVERT: ed7c08417a add static context object which has no capabilities
    REVERT: 496c5b43b8 Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;
    REVERT: bf8b86cc07 secp256k1_fe_sqrt: Verify that the arguments don't alias.
    REVERT: 9bd89c836b Optimize secp256k1_fe_normalize_weak calls. Move secp256k1_fe_normalize_weak calls out of ECMULT_TABLE_GET_GE and ECMULT_TABLE_GET_GE_STORAGE and into secp256k1_ge_globalz_set_table_gej instead.
    REVERT: 52ab96fedb clean dependendies in field_*_impl.h
    REVERT: deff5edd42 Correct math typos in field_*.h
    REVERT: 4efb3f8dd1 Add check that restrict pointers don't alias with all parameters.
    REVERT: 3965027c81 Summarize build options in configure script
    REVERT: 0f0517369c Fix algorithm selection in bench_ecmult
    REVERT: 8b3841c91d fix bug in fread() failure check
    REVERT: cddef0c0be tests: add warning message when /dev/urandom fails
    REVERT: 270f6c80db Portability fix for the configure scripts generated
    
    git-subtree-dir: src/secp256k1
    git-subtree-split: 763484a1e5bed2b8b990e71c2f66129ae1038d59
Commits on Mar 31, 2019
  1. Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063

    sipa committed Mar 31, 2019
    b19c000063 Merge bitcoin#607: Use size_t shifts when computing a size_t
    4d01bc2d9c Merge bitcoin#606: travis: Remove unused sudo:false
    e6d01e9347 Use size_t shifts when computing a size_t
    7667532bd7 travis: Remove unused sudo:false
    ee99f12f3d Merge bitcoin#599: Switch x86_64 asm to use "i" instead of "n" for immediate values.
    d58bc93f2c Switch x86_64 asm to use "i" instead of "n" for immediate values.
    05362ee042 Merge bitcoin#597: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
    83483869ac Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build
    aa15154a48 Merge bitcoin#568: Fix integer overflow in ecmult_multi_var when n is large
    2277af5ff0 Fix integer overflow in ecmult_multi_var when n is large
    85d0e1bcce Merge bitcoin#591: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
    14196379ec Merge bitcoin#580: Add trivial ecmult_multi algorithm which does not require a scratch space
    a697d82da9 Add trivial ecmult_multi to the benchmark tool
    bade617417 Add trivial ecmult_multi algorithm. It is selected when no scratch space is given and just multiplies and adds the points.
    5545e13dea Merge bitcoin#584: configure: Use CFLAGS_FOR_BUILD when checking native compiler
    20c5869df2 Merge bitcoin#516: improvements to random seed in src/tests.c
    b76e45d5d6 Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing.
    870a977644 Merge bitcoin#562: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
    be40c4d0b5 Fixup for C90 mixed declarations.
    c71dd2c08f Merge bitcoin#509: Fix algorithm selection in bench_ecmult
    6492bf88cc Merge bitcoin#518: Summarize build options after running configure
    0e9ada1941 Merge bitcoin#567: Correct order of libs returned on pkg-config --libs --static libsecp2…
    e96901a4b9 Merge bitcoin#587: Make randomization of a non-signing context a noop
    58df8d03ad Merge bitcoin#511: Portability fix for the configure scripts generated
    2ebdad772a Merge bitcoin#552: Make constants static:
    1c131affd3 Merge bitcoin#551: secp256k1_fe_sqrt: Verify that the arguments don't alias.
    ba698f883b Merge bitcoin#539: Assorted minor corrections
    949e85b009 Merge bitcoin#550: Optimize secp256k1_fe_normalize_weak calls.
    a34bcaadf1 Actually pass CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD to linker
    2d5f4cebdc configure: Use CFLAGS_FOR_BUILD when checking native compiler
    b408c6a8b2 Merge bitcoin#579: Use __GNUC_PREREQ for detecting __builtin_expect
    6198375218 Make randomization of a non-signing context a noop
    c663397f46 Use __GNUC_PREREQ for detecting __builtin_expect
    e34ceb333b Merge bitcoin#557: Eliminate scratch memory used when generating contexts
    b3bf5f99a3 ecmult_impl: expand comment to explain how effective affine interacts with everything
    efa783f8f0 Store z-ratios in the 'x' coord they'll recover
    ffd3b346fe add `secp256k1_ge_set_all_gej_var` test which deals with many infinite points
    84740acd2a ecmult_impl: save one fe_inv_var
    47045270fa ecmult_impl: eliminate scratch memory used when generating context
    7f7a2ed3a8 ecmult_gen_impl: eliminate scratch memory used when generating context
    314a61d724 Merge bitcoin#553: add static context object which has no capabilities
    89a20a8945 Correct order of libs returned on pkg-config --libs --static libsecp256k1 call.
    1086fda4c1 Merge bitcoin#354: [ECDH API change] Support custom hash function
    d3cb1f95eb Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
    40fde611bd prevent attempts to modify `secp256k1_context_no_precomp`
    ed7c08417a add static context object which has no capabilities
    496c5b43b8 Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;
    bf8b86cc07 secp256k1_fe_sqrt: Verify that the arguments don't alias.
    9bd89c836b Optimize secp256k1_fe_normalize_weak calls. Move secp256k1_fe_normalize_weak calls out of ECMULT_TABLE_GET_GE and ECMULT_TABLE_GET_GE_STORAGE and into secp256k1_ge_globalz_set_table_gej instead.
    52ab96fedb clean dependendies in field_*_impl.h
    deff5edd42 Correct math typos in field_*.h
    4efb3f8dd1 Add check that restrict pointers don't alias with all parameters.
    1e6f1f5ad5 Merge bitcoin#529: fix tests.c in the count == 0 case
    c8fbc3c397 [ECDH API change] Allow pass arbitrary data to hash function
    b00be65056 [ECDH API change] Support custom hash function
    95e99f196f fix tests.c in the count == 0 case
    452d8e4d2a Merge bitcoin#523: scratch: add stack frame support
    6fe50439ae scratch: add stack frame support
    9bc2e26502 Merge bitcoin#522: parameterize ecmult_const over input size
    7c1b91ba4b parameterize ecmult_const over input size
    dbc3ddd5e2 Merge bitcoin#513: Increase sparsity of pippenger fixed window naf representation
    3965027c81 Summarize build options in configure script
    0f0517369c Fix algorithm selection in bench_ecmult
    fb9271dcf0 Merge bitcoin#510: add a couple missing `const`s to ecmult_pippenger_wnaf
    cd5f6028e5 Merge bitcoin#515: Fix typo
    09146ae854 Merge bitcoin#512: secp256k1_ec_privkey_negate - fix documentation
    ec0a7b3ae3 Don't touch leading zeros in wnaf_fixed.
    9e36d1bfe2 Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar.
    96f68a0afc Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros.
    8b3841c91d fix bug in fread() failure check
    cddef0c0be tests: add warning message when /dev/urandom fails
    9b7c47a21e Fix typo
    6dbb007869 Increase sparsity of pippenger fixed window naf representation
    1646ace4d5 secp256k1_ec_privkey_negate - fix documentation
    270f6c80db Portability fix for the configure scripts generated
    9b3ff0309d add a couple missing `const`s to ecmult_pippenger_wnaf
    cd329dbc3e Merge bitcoin#460: [build] Update ax_jni_include_dir.m4 macro
    7f9c1a1565 Merge bitcoin#498: tests: Avoid calling fclose(...) with an invalid argument
    f99aa8d4d3 Merge bitcoin#499: tests: Make sure we get the requested number of bytes from /dev/urandom
    b549d3d5f7 Merge bitcoin#472: [build] Set --enable-jni to no by default instead of auto.
    d333521516 Merge bitcoin#494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
    2ef8ea5d21 Merge bitcoin#495: Add bench_ecmult to .gitignore
    82a96e4587 tests: Make sure we get the requested number of bytes from /dev/urandom
    5aae5b5bb2 Avoid calling fclose(...) with an invalid argument
    cb32940df3 Add bench_ecmult to .gitignore
    31abd3ab8d Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS
    c95f6f1360 Merge bitcoin#487: fix tests typo, s/changed/unchanged
    fb46c83881 Merge bitcoin#463: Reduce usage of hardcoded size constants
    02f5001dfc Merge bitcoin#490: Disambiguate bench functions and types
    1f46d6089e Disambiguate bench functions and types
    f54c6c5083 Merge bitcoin#480: Enable benchmark building by default
    c77fc08597 Merge bitcoin#486: Add pippenger_wnaf for multi-multiplication
    d2f9c6b5dc Use more precise pippenger bucket windows
    4c950bbeaf Save some additions per window in _pippenger_wnaf
    a58f543f5a Add flags for choosing algorithm in ecmult_multi benchmark
    36b22c9337 Use scratch space dependent batching in ecmult_multi
    355a38f113 Add pippenger_wnaf ecmult_multi
    bc65aa794e Add bench_ecmult
    dba5471b69 Add ecmult_multi tests
    8c1c831bdb Generalize Strauss to support multiple points
    548de42ecf add resizeable scratch space API
    0e96cdc6b6 fix typo, s/changed/unchanged
    c7680e570f Reduce usage of hardcoded size constants
    6ad5cdb42a Merge bitcoin#479: Get rid of reserved _t in type names
    7a78f60598 Print whether we're building benchmarks
    4afec9f1ae Build benchmarks by default
    d1dc9dfc0a Get rid of reserved _t in type names
    57752d28b3 [build] Set --enable-jni to no by default instead of auto.
    e7daa9b3c2 [build] Tweak JNI macro to warn instead of error for JNI not found.
    5b22977922 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS
    
    git-subtree-dir: src/secp256k1
    git-subtree-split: b19c000063be11018b4d1a6b0a85871ab9d0bdcf
Commits on Mar 29, 2019
  1. Merge bitcoin#15669: rpc: Fix help text for signtransactionwithXXX

    MarcoFalke committed Mar 29, 2019
    afc06fc rpc: Fix help text for signtransactionwithXXX (Torkel Rogstad)
    
    Pull request description:
    
      This PR fixes the help text for the `signrawtransactionwithwallet` and `signrawtransactionwithkey` RPC calls. They both marked the `amount` field in the UTXO dependencies as required. This field is omitted in the [`rpc_rawtransaction.py` test](https://github.com/bitcoin/bitcoin/blob/8a8b03ecd2218dcdbcbf3127f2fa94f0f0da4698/test/functional/rpc_rawtransaction.py#L155) and [`successful_signing_test`](https://github.com/bitcoin/bitcoin/blob/8a8b03ecd2218dcdbcbf3127f2fa94f0f0da4698/test/functional/rpc_signrawtransaction.py#L42) in `rpc_signrawtransaction.py`.
    
    ACKs for commit afc06f:
      promag:
        utACK afc06fc.
      MarcoFalke:
        utACK afc06fc
    
    Tree-SHA512: 7847844ca38d8033fef2f5255700d21487d78a63ecee8b80362fa28fadfafc80ba29a89f38d7ebb3a1be4c7d47ff6c338f67afec9ee22bf065fb352bb3d03d3a
  2. Merge bitcoin#15533: test: .style.yapf: Set column_limit=160

    MarcoFalke committed Mar 29, 2019
    1111f07 test: .style.yapf: Set column_limit=160 (MarcoFalke)
    
    Pull request description:
    
      The current style is pep8, as suggested in https://github.com/bitcoin/bitcoin/blob/master/test/functional/README.md#style-guidelines.
    
      generated with
    
      ```
      $ yapf --version
      yapf 0.24.0
      $ yapf --style-help --style=pep8 > .style.yapf
      ```
    
      However, we don't use the column_limit of 79 right now. Practically it is somewhere between 120-240.
    
      Some stats:
    
      ```
      column_limit=120: 115 files changed, 2423 insertions(+), 1408 deletions(-)
      column_limit=160: 108 files changed, 1563 insertions(+), 1247 deletions(-)
      column_limit=200: 104 files changed, 1255 insertions(+), 1178 deletions(-)
    
    ACKs for commit 1111f0:
      practicalswift:
        utACK 1111f07 agree with @ryanofsky
      ryanofsky:
        utACK 1111f07
    
    Tree-SHA512: 1ce0da83b917496f4ea7d1af31b624517a78998a10091b6ba611737f2c819fa3cda1786307f15d20131a00fd95232818e3d1108950dd12b60c4674eaa447839f
  3. Merge bitcoin#15683: Comment for seemingly duplicate LIBBITCOIN_SERVER

    MarcoFalke committed Mar 29, 2019
    2a1408c Comment for seemingly duplicate LIBBITCOIN_SERVER (Peter Bushnell)
    
    Pull request description:
    
      Added a comment to explain the addition of LIBBITCOIN_SERVER twice in bitcoind_LDADD which seems incorrect at a glance until the behaviour of Linux linkers is understood.
    
    ACKs for commit 2a1408:
      practicalswift:
        ACK 2a1408c
      MarcoFalke:
        ACK 2a1408c
      fanquake:
        utACK 2a1408c
      ryanofsky:
        utACK 2a1408c
    
    Tree-SHA512: dd2a7f61d53ce8882a56c831c32e1f48e9eab741ef21361f195c38bb455abdc4bc524d3b44b6f69c7498898cd871a23c39d215de28db3b20ef5fd2135d5e136a
  4. Merge bitcoin#15686: [tests] make pruning test faster

    MarcoFalke committed Mar 29, 2019
    03d6d23 [tests] make pruning test faster (John Newbery)
    1c29ac4 [tests] style fixes in feature_pruning.py (John Newbery)
    
    Pull request description:
    
      This commit makes the pruning.py much faster.
    
      Key insights to do this:
    
      - pruning.py doesn't care what kind of transactions make up the big
      blocks that are pruned in the test. Instead of making blocks with
      several large, expensive to construct and validate transactions,
      instead make the large blocks contain a single coinbase transaction with
      a huge OP_RETURN txout.
      - avoid stop-starting nodes where possible.
    
    ACKs for commit 03d6d2:
      MarcoFalke:
        utACK 03d6d23
    
    Tree-SHA512: 511642ce0fa294319dce3486fe06d75970d8ab66deda7f692be081d3056b4ce5b4cf91a7b5762eefbba224ba6c848750016454ff1e5d564acc507b1c41213628
  5. [tests] make pruning test faster

    jnewbery committed Jun 13, 2017
    This commit makes the pruning.py much faster.
    
    Key insights to do this:
    
    - pruning.py doesn't care what kind of transactions make up the big
    blocks that are pruned in the test. Instead of making blocks with
    several large, expensive to construct and validate transactions,
    instead make the large blocks contain a single coinbase transaction with
    a huge OP_RETURN txout.
    - avoid stop-starting nodes where possible.
    
    This test could probably be made even faster by using the P2P interface
    for submitting blocks instead of the submitblock RPC.
  6. [tests] style fixes in feature_pruning.py

    jnewbery committed Mar 29, 2019
    Minor style fixups. No functional change.
  7. Merge bitcoin#15255: [tests] Remove travis_wait from lint script

    MarcoFalke committed Mar 29, 2019
    8b8d8ee Remove travis_wait from lint script (Graham Krizek)
    
    Pull request description:
    
      Using the `travis_wait` command in conjunction with `set -o errexit` causes problems. The `travis_wait` command will correctly log the command's output if successful, but if the command fails the process exits before the `travis_wait` command can dump the logs. This will hide important debugging information like error messages and stack traces. We ran into this in bitcoin#15196 and it was very hard to debug because output was being suppressed.
    
      `travis_wait` was being used because the `contrib/verify-commits/verify-commits.py` script can sometimes run for a long time without producing any output. If a script runs for 10 minutes without logging anything, the CI run times out. The `travis_wait` command will extend this timeout by logging a message for you, while sending stderr and stdout to a file.
    
      This PR removes the `travis_wait` command from our CI system and adds additional logging to the `verify-commits.py` script so it doesn't make Travis timeout.
    
    ACKs for commit 8b8d8e:
      MarcoFalke:
        utACK 8b8d8ee
    
    Tree-SHA512: 175a8dd3f4d4e03ab272ddba94fa8bb06875c9027c3f3f81577feda4bc8918b5f0e003a19027f04f8cf2d0b56c68633716a6ab23f95b910121a8d1132428767d
  8. Merge bitcoin#15663: crypto: Remove unused AES-128 code

    jonasschnelli committed Mar 29, 2019
    f6ee177 Remove unused AES-128 code (practicalswift)
    
    Pull request description:
    
      Remove unused AES-128 code.
    
      As far as I can tell this AES-128 code has never been in use in the project (outside of testing/benchmarking).
    
      The AES-256 code is used in `CCrypter::Encrypt`/`CCrypter::Decrypt` (`src/wallet/crypter.cpp`).
    
      Trivia: 0.15% of the project's C++ LOC count (excluding dependencies) is trimmed off:
    
      ```
      $ LOC_BEFORE=$(git grep -I "" HEAD~1 -- "*.cpp" "*.h" ":(exclude)src/leveldb/" ":(exclude)src/secp256k1/" ":(exclude)src/univalue/" | wc -l)
      $ LOC_AFTER=$(git grep -I "" -- "*.cpp" "*.h" ":(exclude)src/leveldb/" ":(exclude)src/secp256k1/" ":(exclude)src/univalue/" | wc -l)
      $ bc <<< "scale=4; ${LOC_AFTER}/${LOC_BEFORE}"
      .9985
      ```
    
      :-)
    
    Tree-SHA512: 9588a3cd795a89ef658b8ee7323865f57723cb4ed9560c21de793f82d35e2835059e7d6d0705e99e3d16bf6b2a444b4bf19568d50174ff3776caf8a3168f5c85
Commits on Mar 28, 2019
  1. Merge bitcoin#15616: rpc: Clarify decodescript RPCResult doc

    MarcoFalke committed Mar 28, 2019
    fa926ec rpc: Mention all output types in decodescript doc (MarcoFalke)
    fa3caa1 rpc: decodescript use IsValidNumArgs over hardcoded check (MarcoFalke)
    faad33f rpc: Clarify decodescript RPCResult doc (MarcoFalke)
    
    Pull request description:
    
      * Remove `"hex"` from the decodescript RPCResult doc
      * Add `"segwit`" to the doc
    
      Follow up to a6099ef and 4f933b3
    
    ACKs for commit fa926e:
      ryanofsky:
        utACK fa926ec. Only change since last review is listing possible output types in the help string using a new `GetAllOutputTypes` function
    
    Tree-SHA512: e6ecc563d04769942567118d50188467bf64ceb276ba6268928d469e8f06621f2ca1ae1e555d3daa6ec22a615ee259bb31c4141c19818d0f53fb6c529b18381b
  2. Merge bitcoin#15684: doc/dependencies: Fix typo libsrvg->librsvg

    MarcoFalke committed Mar 28, 2019
    7d01b5c doc/dependencies: Fix typo libsrvg->librsvg (Luke Dashjr)
    
    Pull request description:
    
    ACKs for commit 7d01b5:
      practicalswift:
        ACK 7d01b5c
    
    Tree-SHA512: f04e20a482df586ae60fae68a94c53b7a3efcdd050bc60eed5b3ac51e1f8ac4b5016290302b1729fcd4ac600393fd163ebf01c919583efa8ddde44f7a5de5462
  3. Merge bitcoin#15682: release: Update the Windows Codesigning certificate

    laanwj committed Mar 28, 2019
    43ae1e9 release: Update the Windows Codesigning certificate (Cory Fields)
    
    Pull request description:
    
      Thanks to @gwillen for paying and @jonasschnelli for setting up the small company needed for signing!
    
      This updates the Windows codesigning certificate to replace our expired one.
    
      Testing showed that Windows 7 had trouble finding the path to a trusted CA. I am not sure if this will work better with more recent Windows versions, but because the previous cert is expired, this can only be an improvement.
    
      This needs feedback after rc3.
    
    ACKs for commit 43ae1e:
      laanwj:
        utACK 43ae1e9
      achow101:
        utACK 43ae1e9
    
    Tree-SHA512: 2e70591d2deeac5f6e73d73474ccefba5db6cfd9004c40a56c7c2d8300b67ccee4916a04f43e0b75796cc1089d111e30276819e0bfb954c63c4760b8d96423a4
Older
You can’t perform that action at this time.