From fd44d58f48fff1036bfde9b8a7e4166678fe7dfd Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Thu, 25 Sep 2025 10:49:36 -0300 Subject: [PATCH 1/3] [BUGFIX] SonarQube: Prefer class field declaration over `this` assignment in constructor for static values. Class properties should be declared as fields rather than assigned in constructors javascript:S7757 --- .../interview_preparation_kit/sort/ctci_bubble_sort.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/hackerrank/interview_preparation_kit/sort/ctci_bubble_sort.js b/src/hackerrank/interview_preparation_kit/sort/ctci_bubble_sort.js index b5c4af8c..0b66483d 100644 --- a/src/hackerrank/interview_preparation_kit/sort/ctci_bubble_sort.js +++ b/src/hackerrank/interview_preparation_kit/sort/ctci_bubble_sort.js @@ -5,12 +5,11 @@ const SEPARATOR = '\n'; class SortableGroup { - group; + count = 0; - count; + group; constructor(group) { - this.count = 0; this.group = group; } From a2341ae510856d8e718bfa164650a49c5a544651 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Thu, 25 Sep 2025 11:32:57 -0300 Subject: [PATCH 2/3] [BUGFIX] SonarQube: Prefer class field declaration over `this` assignment in constructor for static values. Class properties should be declared as fields rather than assigned in constructors javascript:S7757 --- .../dynamic_programming/max_array_sum.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js b/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js index 4b2e49ac..b40ec95d 100644 --- a/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js +++ b/src/hackerrank/interview_preparation_kit/dynamic_programming/max_array_sum.js @@ -7,7 +7,7 @@ const bigIntMax = (...args) => args.reduce((m, e) => (e > m ? e : m), BigInt(0)); function maxSubsetSum(arr) { - const arrCopy = arr.map((x) => BigInt(x)); + const arrCopy = arr.map(BigInt); if (arrCopy.length === 0) { return 0; From 90894c37d06e0b0bed2bc22c497368e319c319f8 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Thu, 25 Sep 2025 11:34:48 -0300 Subject: [PATCH 3/3] [BUGFIX] SonarQube: Do not call `Array#push()` multiple times. Multiple consecutive calls to methods that accept multiple arguments should be combined javascript:S7778 --- src/hackerrank/implementation/countApplesAndOranges.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/hackerrank/implementation/countApplesAndOranges.js b/src/hackerrank/implementation/countApplesAndOranges.js index e30960f7..202197f6 100644 --- a/src/hackerrank/implementation/countApplesAndOranges.js +++ b/src/hackerrank/implementation/countApplesAndOranges.js @@ -18,9 +18,7 @@ function countApplesAndOranges(s, t, a, b, apples, oranges) { } } - const result = []; - result.push(cApples); - result.push(cOranges); + const result = [cApples, cOranges]; return result.join('\n'); }