diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php index 1a1e7824..9518e9c8 100644 --- a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php +++ b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php @@ -1075,7 +1075,7 @@ protected function checkForPassByReferenceFunctionCall(File $phpcsFile, $stackPt if ($ptr === $stackPtr) { continue; } - if ($tokens[$ptr]['code'] !== T_WHITESPACE) { + if (isset(Tokens::$emptyTokens[$tokens[$ptr]['code']]) === false) { return false; } } diff --git a/VariableAnalysis/Tests/CodeAnalysis/fixtures/FunctionWithReferenceFixture.php b/VariableAnalysis/Tests/CodeAnalysis/fixtures/FunctionWithReferenceFixture.php index 641f2294..2f0bd8bb 100644 --- a/VariableAnalysis/Tests/CodeAnalysis/fixtures/FunctionWithReferenceFixture.php +++ b/VariableAnalysis/Tests/CodeAnalysis/fixtures/FunctionWithReferenceFixture.php @@ -32,7 +32,7 @@ function function_with_pass_by_reference_calls() { echo $matches; echo $needle; echo $haystack; - preg_match('/(abc)/', 'defabcghi', $matches); + preg_match('/(abc)/', 'defabcghi', /* comment */ $matches); preg_match($needle, 'defabcghi', $matches); preg_match('/(abc)/', $haystack, $matches); echo $matches;