Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update help.c to fix security bug #38

Closed
wants to merge 3 commits into from
Closed

update help.c to fix security bug #38

wants to merge 3 commits into from

Conversation

evilmog
Copy link

@evilmog evilmog commented May 3, 2020

path traversal in help.c allows administrative paths to be read

path traversal in help.c allows administrative paths to be read
Copy link
Owner

@sirdude sirdude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but this doesn't fix it right now it's declaring a var and then not setting it but checking it.
It also has some extra cruft, adds another unused var.

@evilmog
Copy link
Author

evilmog commented May 3, 2020 via email

added missing parts of the pr, sorry about that
@evilmog
Copy link
Author

evilmog commented May 3, 2020

Updated fix, sorry about that, please re-review

Copy link
Author

@evilmog evilmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed, fixes implemented (incomplete copy and paste), also added CVE-2020-12649 reference as assigned

@evilmog evilmog requested a review from sirdude May 5, 2020 00:20
@sirdude
Copy link
Owner

sirdude commented May 5, 2020

Sorry this still doesn't work, it breaks help wiz/bootcamp for example.
I've put in a fix though. Basically test to make sure we are in our subdir /docs/help before processing.

@sirdude sirdude closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants