Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install 6.8.1 version error #747

Closed
lxlxw opened this issue Jul 23, 2019 · 2 comments
Closed

install 6.8.1 version error #747

lxlxw opened this issue Jul 23, 2019 · 2 comments

Comments

@lxlxw
Copy link

lxlxw commented Jul 23, 2019

gulp package --version=6.8.1

/usr/share/kibana/plugins/sentinl/server/lib/helpers.js:60
return collect.concat(paths.map((path) => ({ ...route, path })));
^^^

SyntaxError: Unexpected token ...
at createScript (vm.js:56:10)
at Object.runInThisContext (vm.js:97:10)
at Module._compile (module.js:549:28)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.require (module.js:504:17)
at require (internal/module.js:20:19)
at Object. (/usr/share/kibana/plugins/sentinl/server/lib/actions/report/install_phantomjs.js:4:59)
at Module._compile (module.js:577:32)
at Object.Module._extensions..js (module.js:586:10)
at Module.load (module.js:494:32)
at tryModuleLoad (module.js:453:12)
at Function.Module._load (module.js:445:3)
at Module.require (module.js:504:17)
@lxlxw
Copy link
Author

lxlxw commented Jul 23, 2019

gulp package --version=6.8.1
error...
please..thx!

@JogiInnov
Copy link

+1

lmangani pushed a commit that referenced this issue Aug 21, 2020
@daradermody
Fix impersonation failure when using the watcher play button (#747)
1b4fa67
pull bot pushed a commit to rpatil524/sentinl that referenced this issue Feb 7, 2021
@daradermody @sergibondarenko
Fix impersonation failure when using the watcher play button (sentinl…
47005bf 
…#747)
pull bot pushed a commit to rpatil524/sentinl that referenced this issue Feb 7, 2021
@sergibondarenko
Sync updates and fixes from private (sentinl#550)
3e4bb25 
* Introduce sentinl adv settings (sentinl#706)

* Create register_feature.js

* Update index.js

* use discover icon until we have a proper one

* Update index.js

* Add files via upload

use dedicated icon from plugin

update svg icon

* Use latest lodash to avoid security vulnerability.

* No more restarting in dev mode because of PhantomJs (sentinl#739)

* Add next execution message to the 'every' schedule so that showing timezone makes sense

* Shows actions list if the title panel is valid, not if the period has data (sentinl#746)

* Fix impersonation failure when using the watcher play button (sentinl#747)

* Added a migration to remove sentinl-script objects

* QA fixes

* Fixed wrong import path

* Using string literal for directive name to avoid crash in production servers due to webpack optimization (sentinl#764)

* Add Elasticsearch API to allow user handle Santinl watchers in a custom index.
Do not use deprecated ES types in WatcherHandler.

Save watcher to an index specified in 'default_index' using Elasticsearch API directly.

Correctly handle API responses. Other tiny fixes.

Deprecate ServerConfig. Config values are injected in UI via sentinlConfig.

Make watcher custom index ES6+ compatible only.
Provide types (watcher, user, script) from config to Kibana savedObjectsAPI classes.

Add script and users routes.

Move Sentinl ES API query code to the SavedObjects parent class. It will be used by the class children: user, watcher, script etc.
Remove some method description where it describes obvious things.

Check for object type mapping name.

Create a user via ES API. Delete an obsolete user route.

Never save user password to watcher doc.

Remove ES5 related code.

Never save user password to watcher doc in the adv watcher too.

Use type names specified in config.

Correctly create user id. User id has format: 'sentinl-user:123qwer', where '123qwer' is watcher id. There is only one user per watcher.

Kibana adds object type to id automatically.

Fix tests.

Add dummy sentinlConfig service for tests. Remove unused config route from test.

Use ngMock to create factory in kibana module.

Use 'custom_index' to define 'default_index' value. Thus corrctly making switch between APIs: savedObjectsAPI and ES API.

Rename file.

Start Sentinl only if elasticsearch plugin status is green. Create custom index only if custom_index is defined. Remove unused code.

Multiple fixes for tests.

We must register mapping by kibanaPlugin 'mappings' hook.

I have to put it under isKibi condition because there is the following error in Kibana 6.2.4:
optmzr   error  [07:11:38.242] [fatal] ReferenceError: regeneratorRuntime is not defined
    at /media/trex/safe/Development/siren/kibana/plugins/sentinl/node_modules/kibiutils/lib/migrations/migration.js:48:36
    at /media/trex/safe/Development/siren/kibana/plugins/sentinl/node_modules/kibiutils/lib/migrations/migration.js:68:6
    at Object.<anonymous> (/media/trex/safe/Development/siren/kibana/plugins/sentinl/node_modules/kibiutils/lib/migrations/migration.js:240:2)
    at Module._compile (module.js:652:30)
    at Module._extensions..js (module.js:663:10)
    at Object.require.extensions.(anonymous function) [as .js] (/media/trex/safe/Development/siren/kibana/node_modules/babel-register/lib/node.js:152:7)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/media/trex/safe/Development/siren/kibana/plugins/sentinl/lib/migrations/migrations_5/migration_1.js:1:1)
    at Module._compile (module.js:652:30)
    at loader (/media/trex/safe/Development/siren/kibana/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/media/trex/safe/Development/siren/kibana/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/media/trex/safe/Development/siren/kibana/plugins/sentinl/init.js:51:1)
    at Module._compile (module.js:652:30)

A proposal. Use factory design pattern to pick the required API: savedObjectsAPI or ES API.

Separate ES API and savedObjectsAPI UI services using factory design pattern.

Drop obsolete tests.

There is no need in custom_index config options, use default_index instead.

Make SentinlApi class throw errors when:
1) instantiated
2) children methods are no overwritten

Elasticsearch plugin should always be there.

* Fixes issue creating templates for ES5 (sentinl#781)

* Remove unnecessary brackets

* Updated doc for watcher wizard (sentinl#793)

* Cancelling the warning about a duplicate watcher no longer redirects

Had to handle 'non fatal errors' from the saved objects save function, where no error is thrown but returned ID is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lmangani @lxlxw @JogiInnov