Update TextInput to handle text overflow. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a _text_offset value which records the current left index of the viewable space. Change the key handling code to be more modular and remove redundant code paths which end up with the same result. Add _text_offset updating in the key handling code.
- update docstrings in new and existing TextInput methods - add docstrings for attributes to support VSCode on-hover docstrings - update readme with note about support for text overflow
sirfuzzalot
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies TextInput to handle arbitrarily large inputs
that previously would overflow off the terminal and
become unreadable.
Add a _text_offset value which records the current
left index of the viewable space.
Change the key handling code to be more modular and
remove redundant code paths which end up with the
same result.
Add _text_offset updating in the key handling code.
There may be better ways of handling some of this, ie
_visible_width.