Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added readOnly for sliders #112

Merged
merged 3 commits into from May 31, 2020
Merged

added readOnly for sliders #112

merged 3 commits into from May 31, 2020

Conversation

Scootworks
Copy link
Contributor

with "off" you can disable the input and use it only for viewing

with "off" you can disable the input and use it only for viewing
@sirinsidiator
Copy link
Owner

Not sure I like this change. inputLocation is used to control the layout. Adding off as a value would overload it with a second functionality for controlling the behaviour. Maybe you can just add a new property readOnly or something?

@Scootworks
Copy link
Contributor Author

yes much better, i've changed it to readOnly tag (and will change the pull request title)

@Scootworks Scootworks changed the title added inputLocation "off" added readOnly for sliders May 24, 2020
@sirinsidiator sirinsidiator added this to the r31 milestone May 25, 2020
@sirinsidiator sirinsidiator merged commit 34e927c into sirinsidiator:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants